After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726255 - y4mdec: Should check for VIDEO_META_API not CROP_META_API
y4mdec: Should check for VIDEO_META_API not CROP_META_API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal minor
: 1.3.1
Assigned To: Nicolas Dufresne (ndufresne)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-13 15:57 UTC by Nicolas Dufresne (ndufresne)
Modified: 2014-03-15 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2014-03-13 15:57:06 UTC 
Adding it here not to forget, but while looking at overall usage of CROP metadata, I notice this weird code:

   y4mdec->video_meta =
          gst_query_find_allocation_meta (query, GST_VIDEO_CROP_META_API_TYPE,
          NULL);

      /* We only need a pool if we need to do stride conversion for downstream */
      if (!y4mdec->video_meta && memcmp (&y4mdec->info, &y4mdec->out_info,

I'm under the impression this is a type of something, as the stride is handled if VIDEO_META is supported. As I don't have time for it, and I have no idea what y4m is, I leave it here.
Comment 1 Sebastian Dröge (slomo) 2014-03-15 11:41:00 UTC 
CROP meta depends on VIDEO meta, it can't work without.
Comment 2 Nicolas Dufresne (ndufresne) 2014-03-15 14:16:22 UTC 
Indeed, sorry I didn't express the bug very well. But basically this element only needs VIDEO_META, but requires CROP_META. It works as you said because you need VIDEO meta when you support crop.
Comment 3 Nicolas Dufresne (ndufresne) 2014-03-15 14:24:27 UTC 
commit b6cd7c41e4fce35c500c6788b835560a3a0c7921
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Mar 15 15:17:43 2014 +0100

    y4mdec: check for VIDEO meta instead of CROP meta
    
    This element only need stride support, but checks for CROP_META, which
    is a bit too much, even though this works as CROP imply having VIDEO
    meta.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=726255