After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726233 - Warn if the user does not have permissions to view journal logs
Warn if the user does not have permissions to view journal logs
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-13 11:38 UTC by David King
Modified: 2015-10-13 09:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch needs improvement (9.73 KB, patch)
2015-04-28 12:49 UTC, Jonathan Kang 		none Details | Review
patch which works right now (8.99 KB, patch)
2015-08-24 10:14 UTC, Jonathan Kang 		committed Details | Review

Description David King 2014-03-13 11:38:02 UTC 
Depending on the systemd-journal setup, the user may need to be in a group to have permissions to read logs, as described in systemd-journald(8). It would be useful to show an in-app notification or other warning if the user does not have permissions to view certain classes of log events.
Comment 1 David King 2014-06-22 17:32:43 UTC 
Journal log files are stored in /var/log/journal/<machine-id>. The machine-id can be found by calling sd_id128_get_machine(). The system journal is called system.journal, and user journals are called user-<uid>.journal. There are variants of the journal filenames with @<uuid> before the .journal. Checking whether the user can read the system and user journal should be sufficient.
Comment 2 Jonathan Kang 2015-04-28 12:49:03 UTC 
Created attachment 302508 [details] [review]
patch needs improvement

In this patch, I show info bar directly in GlWindow, then the GlCategoryList won't be focused when the window is shown. So as the program starts up, the function named gl_category_list_focus won't be called and the program runs in a way we're not expecting. It needs improvement.
Comment 3 Jonathan Kang 2015-08-24 10:14:11 UTC 
Created attachment 309908 [details] [review]
patch which works right now
Comment 4 David King 2015-08-25 07:45:15 UTC 
Review of attachment 309908 [details] [review]:

Looks good! Let's push this only after the development freeze has been lifted.
Comment 5 Jonathan Kang 2015-10-13 09:38:38 UTC 
Pushed to master as commit 61192b29feb963c74fdb38d402740fce620f1423