After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726228 - Sidebar should be hidden when viewing event details
Sidebar should be hidden when viewing event details
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-13 11:10 UTC by David King
Modified: 2014-11-11 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
hide sidebar while viewing event details (60.86 KB, patch)
2014-11-11 12:28 UTC, Jonathan Kang 		committed Details | Review

Description David King 2014-03-13 11:10:15 UTC 
https://wiki.gnome.org/Design/Apps/Logs#Tentative_Design shows the details view without the sidebar visible, so it should be hidden in that view.
Comment 1 Allan Day 2014-04-09 13:11:03 UTC 
Yes, this change makes sense to me - since the sidebar affects the list, which isn't in view. Bonus points here for using a revealer to slide the sidebar in and out. :)
Comment 2 Jonathan Kang 2014-11-11 12:28:09 UTC 
Created attachment 290412 [details] [review]
hide sidebar while viewing event details

hide sidebar while viewing event details
Comment 3 David King 2014-11-11 12:44:16 UTC 
Review of attachment 290412 [details] [review]:

I made some minor adjustments and pushed this to master. Thanks for the many hours that you spent on the patch!