After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726197 - grilo should not ignore ${libdir} and hardcode lib64
grilo should not ignore ${libdir} and hardcode lib64
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks: 726012
 
 
Reported: 2014-03-12 19:32 UTC by Allison Karlitskaya (desrt)
Modified: 2014-03-13 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure: don't hardcode lib64 (971 bytes, patch)
2014-03-12 19:36 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-03-12 19:32:07 UTC 
This code should be removed from grilo's configure.ac:

if test "${libdir}" = '${exec_prefix}/lib'; then
   case `uname -m` in
        x86_64|ppc64|powerpc64)
                libdir='${exec_prefix}/lib64'
        ;;
        *)
                libdir='${exec_prefix}/lib'
        ;;
esac
fi


If someone wants to install in lib64 then they will give this in --libdir.  If they give 'lib' in --libdir then it is not correct to ignore this.  Most systems don't use lib64, and jhbuild is currently moving away from it as well.
Comment 1 Allison Karlitskaya (desrt) 2014-03-12 19:36:46 UTC 
Created attachment 271643 [details] [review]
configure: don't hardcode lib64

If the user wants libraries installed in a directory called lib64 then
they will specify this via the --libdir option.
Comment 2 Bastien Nocera 2014-03-13 08:43:41 UTC 
Review of attachment 271643 [details] [review]:

Looks fine.
Comment 3 Allison Karlitskaya (desrt) 2014-03-13 12:36:39 UTC 
Attachment 271643 [details] pushed as 1d806ab - configure: don't hardcode lib64