After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726186 - Add new api to support filter function in find_nearest_city method
Add new api to support filter function in find_nearest_city method
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-12 16:52 UTC by Saurabh_P
Modified: 2014-04-01 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This suports filter function to find nearest city method (5.55 KB, patch)
2014-03-12 16:54 UTC, Saurabh_P 		reviewed Details | Review
Tried to correct indentation and documentation. (5.03 KB, patch)
2014-03-12 18:39 UTC, Saurabh_P 		reviewed Details | Review
corrected. (5.06 KB, patch)
2014-03-12 21:12 UTC, Saurabh_P 		committed Details | Review

Description Saurabh_P 2014-03-12 16:52:51 UTC 
This api should assume that the app is using geocoding itself and should pass the filter function as an argument to the function to make search process more efficient and strict.
Comment 1 Saurabh_P 2014-03-12 16:54:25 UTC 
Created attachment 271622 [details] [review]
This suports filter function to find nearest city method
Comment 2 Giovanni Campagna 2014-03-12 17:07:55 UTC 
Review of attachment 271622 [details] [review]:

::: libgweather/gweather-location.c
@@ +633,3 @@
+ * longitude, among the descendants of @loc. We are looking for
+ * weather station instead of city to get a metar code information also of the
+ * nearest city.

Just noticed this... who is we here?
Comment 3 Saurabh_P 2014-03-12 17:11:34 UTC 
Oh sorry, I should have written "Look for ... "
Comment 4 Saurabh_P 2014-03-12 18:39:25 UTC 
Created attachment 271639 [details] [review]
Tried to correct indentation and documentation.
Comment 5 Giovanni Campagna 2014-03-12 20:40:18 UTC 
Review of attachment 271639 [details] [review]:

::: libgweather/gweather-location.c
@@ +633,3 @@
+ * longitude, among the descendants of @loc. Looks for the
+ * nearest weather station in foreach_city method instead
+ * of city to get a metar code information for location.

I must say I still don't get what this is supposed to mean...

@@ +652,3 @@
+					GWeatherFilterFunc func,
+					gpointer user_data,
+					GDestroyNotify destroy)

You need to align both the type and the parameter name.
Comment 6 Saurabh_P 2014-03-12 21:12:20 UTC 
Created attachment 271653 [details] [review]
corrected.
Comment 7 Giovanni Campagna 2014-03-12 21:23:03 UTC 
Review of attachment 271653 [details] [review]:

Yep.
Comment 8 Giovanni Campagna 2014-04-01 20:52:14 UTC 
Pushed