After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726154 - wizard: Focus Create button on last page
wizard: Focus Create button on last page
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-12 06:34 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Focus Create button on last page (988 bytes, patch)
2014-03-12 06:38 UTC, Lasse Schuirmann 		needs-work Details | Review
wizard: Focus Create button on last page (925 bytes, patch)
2014-03-12 21:34 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-03-12 06:34:24 UTC 
Please take a look at the appended patch.
Comment 1 Lasse Schuirmann 2014-03-12 06:38:27 UTC 
Created attachment 271576 [details] [review]
wizard: Focus Create button on last page

Since the wizard supports Alt + Left and Alt + Right for navigation,
it is consistent to focus the Create button on the last page to allow
a confirmation via enter.
Comment 2 Zeeshan Ali 2014-03-12 13:15:49 UTC 
Review of attachment 271576 [details] [review]:

Good stuff!

::: src/wizard.vala
@@ +98,3 @@
                     review.begin ((obj, result) => {
                         next_button.sensitive = true;
+                        if (next_button == create_button)

this check is redundant. If you want to ensure that you are focusing the right button, just do create_button.grab_focus() then.
Comment 3 Lasse Schuirmann 2014-03-12 21:34:21 UTC 
Created attachment 271655 [details] [review]
wizard: Focus Create button on last page

Since the wizard supports Alt + Left and Alt + Right for navigation,
it is consistent to focus the Create button on the last page to allow
a confirmation via enter.
Comment 4 Zeeshan Ali 2014-03-12 21:57:13 UTC 
Review of attachment 271655 [details] [review]:

ack
Comment 5 Zeeshan Ali 2014-03-14 13:52:13 UTC 
Attachment 271655 [details] pushed as fb4a786 - wizard: Focus Create button on last page