After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726149 - broadway: remove unused libcrypt
broadway: remove unused libcrypt
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Broadway
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-12 04:13 UTC by Allison Karlitskaya (desrt)
Modified: 2014-03-12 10:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
broadway: remove unused libcrypt (1.57 KB, patch)
2014-03-12 04:13 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-03-12 04:13:38 UTC
eb1ab0dac2f3d7a05cfe8b87e83b363d39279a38 removed support for authentication
based on crypt()-hashed passwords but it didn't remove the header

Finish up with the removal.

This allows the broadway backend to build on FreeBSD (which has no
crypt.h).
Comment 1 Allison Karlitskaya (desrt) 2014-03-12 04:13:40 UTC
Created attachment 271572 [details] [review]
broadway: remove unused libcrypt
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-03-12 04:15:59 UTC
Review of attachment 271572 [details] [review]:

OK.
Comment 3 Allison Karlitskaya (desrt) 2014-03-12 04:17:24 UTC
Attachment 271572 [details] pushed as ff0c470 - broadway: remove unused libcrypt
Comment 4 Alexander Larsson 2014-03-12 10:06:13 UTC
At some point i want to add back the authentication though. Its quite nice if you're running a broadway on a public network. It was removed by jasper for no real reason.