After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726120 - The background is only updated once
The background is only updated once
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: background
3.11.x
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.12
Depends on:
Blocks:
 
 
Reported: 2014-03-11 17:16 UTC by Debarshi Ray
Modified: 2014-03-14 23:44 UTC
See Also:
GNOME target: 3.12
GNOME version: ---


Attachments
background: Destroy redundant backgrounds right after loading (2.54 KB, patch)
2014-03-14 23:22 UTC, Florian Müllner
committed Details | Review

Description Debarshi Ray 2014-03-11 17:16:42 UTC
With 3.11.91 and current Git master, when I change the background for the second time, the new image is not shown on the desktop. However, the thumbnail preview of the workspaces do show the new image.
Comment 1 Matthias Clasen 2014-03-12 14:45:55 UTC
ugh :-(
Comment 2 Ray Strode [halfline] 2014-03-12 14:48:30 UTC
would be interesting to see if Jasper's patch on bug 722149 helps
Comment 3 Debarshi Ray 2014-03-13 09:36:15 UTC
No, current Git master is still broken.
Comment 4 Florian Müllner 2014-03-14 23:22:53 UTC
Created attachment 271974 [details] [review]
background: Destroy redundant backgrounds right after loading

When reacting to background settings changes, we may end up queuing
more than one load. The redundant backgrounds are expected to be
destroyed when the previous background has faded out; however since
commit 933f38390ba1512aa, the tweened actor is the same for all
consecutive load operations and we end up with a single onComplete
handler, ergo a single destroyed actor.
As new backgrounds are always added to the bottom, we are not only
piling up additional background actors, but break changing backgrounds
more than once, as the correct background ends up being covered by
previously added redundant actors.
Fix this by destroying redundant actors right after loading rather
than waiting for the fade animation to complete.
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-03-14 23:40:49 UTC
Review of attachment 271974 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2014-03-14 23:44:10 UTC
Attachment 271974 [details] pushed as d6197b0 - background: Destroy redundant backgrounds right after loading