GNOME Bugzilla – Bug 726078
After change an instance of a recurring event, the rest of the instances cannot be changed
Last modified: 2014-03-13 02:14:46 UTC
To reproduce: 1 - Create a recurring event 2 - Change only one instance of the series 3 - Try to change another event of the series 4 - See an error in the terminal you're running Evolution Milan, as we have discussed, the attached patch solves the problem. About usage of ews_start_sync, I kept it as it is for now. I didn't see a big gain don't using it, as it runs in its own thread.
Created attachment 271496 [details] [review] Force update after modifying calendar items
Created attachment 271497 [details] [review] Bug #726078 - After change an instance of a recurring event, the rest of the instances cannot be changed
Review of attachment 271497 [details] [review]: OK, it seems to fix the issue. Please commit to master.
Review of attachment 271497 [details] [review]: oops, I take it back. ::: src/calendar/e-cal-backend-ews.c @@ +1069,3 @@ + } + + if (error) { this change is not correct, because the 'error' is eaten by the e_data_cal_respond_remove_objects(); why do you want to spread the error on the factory console and in the UI? @@ +1771,3 @@ + } + + if (error != NULL) { the is not correct, for the same reason as above
Created attachment 271609 [details] [review] Bug #726078 - After change an instance of a recurring event, the rest of the instances cannot be changed
Review of attachment 271609 [details] [review]: Looks fine, please commit to master. Thanks.
Attachment 271609 [details] pushed as 8c8eef2 (evolution-ews 3.11.92+)