After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726069 - frei0rfilter: memory corruption when the size of the incoming buffers change
frei0rfilter: memory corruption when the size of the incoming buffers change
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 725853
 
 
Reported: 2014-03-10 21:53 UTC by Mathieu Duponchelle
Modified: 2014-03-11 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes the reported issue (1.34 KB, patch)
2014-03-10 21:55 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-03-10 21:53:57 UTC 
The following patch fixes an issue that can't be reproduced with gst-launch, as the width or height of the input caps for a frei0rfilter have to be changed during playback.

The patch itself is quite self-explanatory.
Comment 1 Mathieu Duponchelle 2014-03-10 21:55:17 UTC 
Created attachment 271482 [details] [review]
fixes the reported issue
Comment 2 Nicolas Dufresne (ndufresne) 2014-03-11 02:45:10 UTC 
Review of attachment 271482 [details] [review]:

Looks good.
Comment 3 Mathieu Duponchelle 2014-03-11 15:51:13 UTC 
Thanks, pushed

commit 09989e7c71bb10977a94e5279980d8d2e1512514
Author: Mathieu Duponchelle <mduponchelle1@gmail.com>
Date:   Mon Mar 10 22:48:04 2014 +0100

    frei0rfilter: fix memory corruption on sink caps changes.
    
    When the input size changed, the frei0r filters didn't take
    it into account and ended up corrupting memory.
    
    Fixes #726069