After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726057 - Missing ApplicationCommandLine.get_options_dict
Missing ApplicationCommandLine.get_options_dict
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: GLib
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 725994
 
 
Reported: 2014-03-10 19:31 UTC by David King
Modified: 2014-03-13 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add ApplicationCommandLine.get_options_dict to VAPI (814 bytes, patch)
2014-03-10 19:32 UTC, David King
needs-work Details | Review
update VAPI to current gio-2.0 gir (2.77 KB, patch)
2014-03-10 20:34 UTC, David King
none Details | Review

Description David King 2014-03-10 19:31:24 UTC
g_application_command_line_get_options_dict() was missing from the API reference:

https://git.gnome.org/browse/glib/commit/?id=25f36d8e5efb1312bc684a28158ecfba2dd2ace0

It also needs to be added to the gio-2.0.vapi file.
Comment 1 David King 2014-03-10 19:32:33 UTC
Created attachment 271469 [details] [review]
add ApplicationCommandLine.get_options_dict to VAPI
Comment 2 Luca Bruno 2014-03-10 19:42:50 UTC
Review of attachment 271469 [details] [review]:

Thanks for your patch, however gio-2.0.vapi is auto generated. The reason why get_options_dict() is not in the vapi is because in the Gio-2.0.gir it's introspectable=0.
The correct approach is regenerate the bindings with make gio-2.0 with a recent gir, then upload the gir file to the vala-girs repository: https://gitorious.org/vala-girs
Comment 3 David King 2014-03-10 20:34:01 UTC
Created attachment 271473 [details] [review]
update VAPI to current gio-2.0 gir

I could not figure out how to submit a merge request on Gitorious, but the latest GIR is:

https://gitorious.org/vala-girs/amigadaves-vala-girs/commits/4b4721605f0bd530a0ca31a805c0fbcc2df352b2

The attached patch to the VAPI is generated from that GIR.
Comment 4 Luca Bruno 2014-03-13 20:15:46 UTC
commit 3c7a6eb95d908c8af0d7c80533d1ffb605364b4b
Author: David King <amigadave@amigadave.com>
Date:   Mon Mar 10 19:22:38 2014 +0000

    gio-2.0: Update to 2.39.91+
    
    Fixes bug 726057

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.