After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726018 - Enhancement request: Improve the accessibility of the info dialog.
Enhancement request: Improve the accessibility of the info dialog.
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal enhancement
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-10 08:22 UTC by Luke Yelavich
Modified: 2015-02-25 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add atk relationships in the info dialog. (13.97 KB, patch)
2014-03-10 08:22 UTC, Luke Yelavich 		none Details | Review
accessibility patch for info dialog, fixed up for 0.9.10.1 (13.39 KB, patch)
2015-01-27 01:03 UTC, Mathieu Trudel-Lapierre 		none Details | Review
accessibility patch for info dialog, fixed up for 0.9.10.1 again (13.40 KB, patch)
2015-01-27 15:00 UTC, Mathieu Trudel-Lapierre 		none Details | Review

Description Luke Yelavich 2014-03-10 08:22:42 UTC 
Created attachment 271400 [details] [review]
Patch to add atk relationships in the info dialog.

The info dialog would be more useful to screen reader users if proper relationships between an entry, and the label for that entry were in place.

Attached is a patch to do this.

I have tested this change against te 0.9.8.x releases, but have not done so for 0.9.x due to not having a build environment set up with the newer network-manager components.

Thanks in advance for your consideration.
Comment 1 Mathieu Trudel-Lapierre 2015-01-27 01:03:50 UTC 
Created attachment 295487 [details] [review]
accessibility patch for info dialog, fixed up for 0.9.10.1

I fixed up the patch for 0.9.10.1.
Comment 2 Mathieu Trudel-Lapierre 2015-01-27 15:00:35 UTC 
Created attachment 295539 [details] [review]
accessibility patch for info dialog, fixed up for 0.9.10.1 again

Updated the patch again, there were some errors.
Comment 3 Lubomir Rintel 2015-02-07 16:58:31 UTC 
LGTM, applied.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.