After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726015 - rtph264pay: Reset last_spspps to orgin value when NULL state
rtph264pay: Reset last_spspps to orgin value when NULL state
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.2.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-10 07:01 UTC by Göran Jönsson
Modified: 2014-04-21 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (868 bytes, patch)
2014-03-10 07:01 UTC, Göran Jönsson 		needs-work Details | Review
patch (970 bytes, patch)
2014-03-13 08:47 UTC, Göran Jönsson 		committed Details | Review

Description Göran Jönsson 2014-03-10 07:01:45 UTC 
Created attachment 271397 [details] [review]
patch

In file gstrtp264pay,c reset value last_spspps when state transition to NULL.
Attach patch·
Comment 1 Sebastian Dröge (slomo) 2014-03-12 07:42:18 UTC 
Review of attachment 271397 [details] [review]:

::: gst/rtp/gstrtph264pay.c
@@ +1247,3 @@
       break;
+    case GST_STATE_CHANGE_READY_TO_NULL:
+      rtph264pay->last_spspps = -1;

This should be done in PAUSED_TO_READY already. Also there are a few other fields that should be reset, e.g. the sps/pps arrays
Comment 2 Sebastian Dröge (slomo) 2014-03-12 07:42:57 UTC 
Thanks for the patch, looks like there's more that needs to be reset in rtph264pay though :)
Comment 3 Göran Jönsson 2014-03-13 08:47:30 UTC 
Created attachment 271690 [details] [review]
patch
Comment 4 Göran Jönsson 2014-03-13 08:48:48 UTC 
fixed review comments attach new patch
resetspspps2.patch
Comment 5 Wim Taymans 2014-04-21 10:10:55 UTC 
commit 80967c76381ec9abcd3b98cf9c0cf022953ad74e
Author: Göran Jönsson <goranjn@axis.com>
Date:   Thu Mar 13 09:37:48 2014 +0100

    gstrtph264pay: Reset sps pps variable when state change.
    
    Reset last_spspps and sps/pps arrays  when state transition
    GST_STATE_CHANGE_PAUSED_TO_READY.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726015