After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725974 - Support for highlight foreground color
Support for highlight foreground color
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.35.x
Other Linux
: Normal enhancement
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-0-36][needed-next][commit:3c91...
Depends on:
Blocks: 726272
 
 
Reported: 2014-03-09 10:40 UTC by Egmont Koblinger
Modified: 2014-03-27 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add support for highlight foreground color (23.96 KB, patch)
2014-03-13 17:07 UTC, Egmont Koblinger 		committed Details | Review

Description Egmont Koblinger 2014-03-09 10:40:07 UTC 
The highlight background color can be specified via API (vte_terminal_set_color_highlight()) or escape sequences (OSC 17/117).

A counterpart to set the highlight foreground color should also be added (API, and OSC 19/119 as used in xterm).

ChPe/Behdad: Can such a new API call be squeezed in before the 0.36 release?
Comment 1 Christian Persch 2014-03-10 09:35:30 UTC 
IMO yes.
Comment 2 Egmont Koblinger 2014-03-13 17:07:27 UTC 
Created attachment 271761 [details] [review]
Add support for highlight foreground color

Could you please take a look at this patch?

To test it with escape sequences: 
echo -ne '\e]19;#abcdef\a'  # set highlight fg color
echo -ne '\e]119\a'         # reset highlight fg color

Same with 17/117 for bg. Fg/bg are swapped if neither of these two are defined.

I haven't verified the API bits.

VTE_DEF_HL needed to be renamed for consistency. I decided to rename the rest as well, especially VTE_CUR_BG was misleading as the first word that occurred to me was always "current" instead of "cursor" and of course it didn't make any sense.
Comment 3 Egmont Koblinger 2014-03-15 14:33:56 UTC 
Fixed in vte-0-36. Keeping open for vte-next.
Comment 4 Christian Persch 2014-03-27 18:16:17 UTC 
Fixed on master.