After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725958 - NMConnectionSection: don't remove connections that were never added
NMConnectionSection: don't remove connections that were never added
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: network-indicator
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-08 23:09 UTC by Giovanni Campagna
Modified: 2014-03-10 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NMConnectionSection: don't remove connections that were never added (1.61 KB, patch)
2014-03-08 23:09 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-03-08 23:09:24 UTC 
NMApplet will call removeConnection() unconditionally on all sections,
including those that had nothing to do with the connection in the first
place.

Fixes:

Gjs-WARNING **: JS ERROR: TypeError: this._connectionItems.get(...) is undefined
NMConnectionSection<.removeConnection@resource:///org/gnome/shell/ui/status/network.js:323
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
NMApplet<._connectionRemoved@resource:///org/gnome/shell/ui/status/network.js:1885
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Comment 1 Giovanni Campagna 2014-03-08 23:09:28 UTC 
Created attachment 271340 [details] [review]
NMConnectionSection: don't remove connections that were never added
Comment 2 drago01 2014-03-09 13:24:22 UTC 
Review of attachment 271340 [details] [review]:

OK.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-03-09 15:31:07 UTC 
Review of attachment 271340 [details] [review]:

Why don't they have a section in the first place?

This seems like an NM bug workaround.
Comment 4 Giovanni Campagna 2014-03-09 15:35:41 UTC 
(In reply to comment #3)
> Review of attachment 271340 [details] [review]:
> 
> Why don't they have a section in the first place?
> 
> This seems like an NM bug workaround.

I don't follow you, who should have a section?
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-03-09 15:42:55 UTC 
Review of attachment 271340 [details] [review]:

Oh, I see. We don't store a device for a connection. Because connections don't have devices.

I think the NM team wants to change that and pair connections with devices 1:1, but let's do this for now.
Comment 6 Giovanni Campagna 2014-03-10 16:52:00 UTC 
Attachment 271340 [details] pushed as 522f3bf - NMConnectionSection: don't remove connections that were never added