GNOME Bugzilla – Bug 725949
gnome-music buttons have no tooltips
Last modified: 2014-05-05 18:29:46 UTC
tooltips helps in documentation as well as tells about the functionality of a particular button or feature. gnome-music have no tooltips, please let us know when you are planning to add them or not panning at all. Thanks!!
Can you help me, for which button/widgets you want tooltips and what tip should be shown there?
Documents do have tooltips in its buttons, so I think Music should have them too. (In reply to comment #1) > Can you help me, for which button/widgets you want tooltips and what tip should > be shown there? Basically, the buttons in the header bar and the player bar. You could just copy the tooltips for the header bar from Documents and other core apps (they are just common buttons). Buttons in player bar should show Previous, Play/Pause (depending on current state of the center button) and Next.
Created attachment 275553 [details] [review] Patch for player buttons tooltips Hi, I've made a patch for Player buttons (next, prev, play/pause). I've tested the Play/Pause and it works even when the player is paused from outside of application.
Review of attachment 275553 [details] [review]: Looks good to me, could you also prepare a patch for Back and Search buttons?
Created attachment 275655 [details] [review] Added tooltips to back,search, select buttons patch
Review of attachment 275553 [details] [review]: On the second thought we're storing as much UI as possible in UI files, we should add smth like: <property name="tooltip-text" translatable="yes">Add to Playlist</property> to each GtkButton we have in .ui files
Review of attachment 275655 [details] [review]: See previous comment
Created attachment 275905 [details] [review] Added tooltips to header bar and player buttons Good point! I've created new patch with tooltips created in ui files. Play/Pause button functionality is implemented in code.
Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=1d90b9f. As a side note - please make sure that submitted code passes pep8 checks, we're doing our best to be strict about. Nevertheless, thanks for your contribution!