After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725944 - document-panel: add drag'n drop
document-panel: add drag'n drop
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other All
: Normal trivial
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-08 16:42 UTC by sébastien lafargue
Modified: 2014-03-09 20:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
document-panel: add drag'n drop (18.70 KB, patch)
2014-03-08 16:42 UTC, sébastien lafargue 		committed Details | Review
adwaita css part (1.07 KB, patch)
2014-03-08 16:42 UTC, sébastien lafargue 		accepted-commit_now Details | Review

Description sébastien lafargue 2014-03-08 16:42:04 UTC 
Drag'n drop work between :
    
 - document-row of the same group
 - document-row of different groups
 - document-row of different gedit windows
   ( same app, not different standalone windows - created with gedit -s )
Comment 1 sébastien lafargue 2014-03-08 16:42:08 UTC 
Created attachment 271321 [details] [review]
document-panel: add drag'n drop

Drag'n drop work between :

 - document-row of the same group
 - document-row of different groups
 - document-row of different gedit windows
   ( same app, not different standalone windows - created with gedit -s )
Comment 2 sébastien lafargue 2014-03-08 16:42:56 UTC 
Created attachment 271322 [details] [review]
adwaita css part
Comment 3 Paolo Borelli 2014-03-09 12:29:29 UTC 
I have not reviewed the code in detail, but I tested it a bit and it seems working great and the patch is not too big. Beside this is a quite hidden feature so I do not think it is high-risk: I think we should get this in before 3.12.

The only nitpick I have for the patch is that you have a few extra empty lines here and there: for instance we never leave two empty lines between functions.


About the adwaita part I am not 100% convinced of the blue borders for the placeholder... seems a bit "too much": maybe we can experiment with something slightly more subtle?

Anyway feel free to push both patches
Comment 4 sébastien lafargue 2014-03-09 20:26:02 UTC 
Comment on attachment 271321 [details] [review]
document-panel: add drag'n drop

Attachment 271321 [details] pushed as 7931529 - document-panel: add drag'n drop
Comment 5 sébastien lafargue 2014-03-09 20:30:58 UTC 
Review of attachment 271322 [details] [review]:

ok