After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725918 - Chain up to parent dispose and finalize methods
Chain up to parent dispose and finalize methods
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-07 20:59 UTC by Dan Williams
Modified: 2014-06-22 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Ensure-GObject-finalize-and-dispose-methods-chain-up.patch (4.31 KB, patch)
2014-03-07 20:59 UTC, Dan Williams 		committed Details | Review

Description Dan Williams 2014-03-07 20:59:35 UTC 
Created attachment 271267 [details] [review]
0001-Ensure-GObject-finalize-and-dispose-methods-chain-up.patch

Doesn't fix any specific bug right now, but surely will cause problems at some point unless fixed.
Comment 1 Dan Williams 2014-03-07 21:05:17 UTC 
Also, one more to do:

diff --git a/ges/ges-project.c b/ges/ges-project.c
index dfb2497..5a9c500 100644
--- a/ges/ges-project.c
+++ b/ges/ges-project.c
@@ -408,15 +408,15 @@ ges_project_class_init (GESProjectClass * klass)
   _signals[ERROR_LOADING_ASSET] =
       g_signal_new ("error-loading-asset", G_TYPE_FROM_CLASS (klass),
       G_SIGNAL_RUN_LAST, G_STRUCT_OFFSET (GESProjectClass, loading_error),
       NULL, NULL, g_cclosure_marshal_generic,
       G_TYPE_NONE, 3, G_TYPE_ERROR, G_TYPE_STRING, G_TYPE_GTYPE);
 
   object_class->dispose = _dispose;
-  object_class->dispose = _finalize;
+  object_class->finalize = _finalize;
 
   GES_ASSET_CLASS (klass)->extract = ges_project_extract;
 }
 
 static void
 ges_project_init (GESProject * project)
 {
Comment 2 Tim-Philipp Müller 2014-03-08 11:27:38 UTC 
Pushed the patch before seeing the follow-up comment, sorry:

commit 636dcc3a26e91e134516af8485b9fdd9a03e6eed
Author: Dan Williams <dcbw@redhat.com>
Date:   Sat Mar 8 11:26:13 2014 +0000

    ges: fix finalize/dispose mixup
    
    https://bugzilla.gnome.org/show_bug.cgi?id=725918

commit 54367a2d36208e7b697eb435a7d51d88f49f35a9
Author: Dan Williams <dcbw@redhat.com>
Date:   Fri Mar 7 14:48:06 2014 -0600

    ges: Ensure GObject finalize and dispose methods chain up to parents
    
    https://bugzilla.gnome.org/show_bug.cgi?id=725918