GNOME Bugzilla – Bug 725899
Add more place types to GeocodePlace
Last modified: 2014-03-27 18:34:52 UTC
To get a bit better granularity when searching we could add some more types. I went through the amenity category, here: taginfo.openstreetmap.org/keys/amenity#values and choose a few that seemed appropriate. Patch forthcoming.
Created attachment 271229 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category. The icons are, as before, taken from the Maki mapbox set.
Created attachment 271232 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category from http://taginfo.openstreetmap.org/keys/amenity#values The icons are, as before, taken from the Maki mapbox set.
Hmm, I guess this patch should be split up with the fixing up of GEOCODE_PLACE_TYPE_AIRPORT as separate patch.
Created attachment 271235 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category from http://taginfo.openstreetmap.org/keys/amenity#values The icons are, as before, taken from the Maki mapbox set.
Created attachment 271236 [details] [review] Make sure we use the airport type for GeocodePlace
Created attachment 272987 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category from http://taginfo.openstreetmap.org/keys/amenity#values The icons are, as before, taken from the Maki mapbox set.
Created attachment 272988 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category from http://taginfo.openstreetmap.org/keys/amenity#values The icons are, as before, taken from the Maki mapbox set.
Review of attachment 271236 [details] [review]: "More specific place type for airports" would be more appropriate shortlog i think. :) ::: icons/Makefile.am @@ +11,3 @@ scalable_places_poi-restaurant.svg \ + scalable_places_poi-bar.svg \ + scalable_places_poi-airport.svg Should be seperate patch ideally but if not then commit log should reflect this.
Review of attachment 272988 [details] [review]: Looks good but i'd rather icons are added in separate patch.
Review of attachment 271236 [details] [review]: Hmm, ok. Before this patch PLACE_TYPE_AIRPORT wasn't used at all. Maybe "forward: Include PLACE_TYPE_AIRPORT in Nominatim conversion"? ::: icons/Makefile.am @@ +11,3 @@ scalable_places_poi-restaurant.svg \ + scalable_places_poi-bar.svg \ + scalable_places_poi-airport.svg I'll split it out.
Review of attachment 272988 [details] [review]: Thanks. Ok!
Created attachment 273026 [details] [review] Add amenity place types to GeocodePlace The place types selected here are among the top of the amenity category from http://taginfo.openstreetmap.org/keys/amenity#values
Created attachment 273027 [details] [review] Add icons for new amenity place types
Created attachment 273028 [details] [review] forward: Include airport place type in results
Created attachment 273029 [details] [review] build: Add icon for airtport place type
Review of attachment 273026 [details] [review]: ack
Review of attachment 273027 [details] [review]: ack
Review of attachment 273028 [details] [review]: ack
Review of attachment 273029 [details] [review]: Isn't the code to actually use the icon missing?
Review of attachment 273029 [details] [review]: It was already there, the place type in forward and the switch case in place already had AIRPORT support. What was missing was the icon and setting it from OSM attributes.
Review of attachment 273029 [details] [review]: Ah ok, then I guess this patch comes before the others (where its used?).
(In reply to comment #21) > Review of attachment 273029 [details] [review]: > > Ah ok, then I guess this patch comes before the others (where its used?). Yeah.
Attachment 273026 [details] pushed as 9b0b84c - Add amenity place types to GeocodePlace Attachment 273027 [details] pushed as abbba5b - Add icons for new amenity place types Attachment 273028 [details] pushed as 7eb1490 - forward: Include airport place type in results Attachment 273029 [details] pushed as 4d4d5b5 - build: Add icon for airtport place type