After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725891 - gio tests: add codegen to BUILT_SOURCES
gio tests: add codegen to BUILT_SOURCES
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-03-07 12:47 UTC by Allison Karlitskaya (desrt)
Modified: 2014-03-07 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio tests: add codegen to BUILT_SOURCES (1.36 KB, patch)
2014-03-07 12:47 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-03-07 12:47:12 UTC 
We need to have these in BUILT_SOURCES so that 'make' knows to generate them
before attempting to compile other .c files in the same directory (since some
of these files include the header).

Should fix up remaining issues about partial versions of this file being
included under parallel builds.
Comment 1 Allison Karlitskaya (desrt) 2014-03-07 12:47:14 UTC 
Created attachment 271212 [details] [review]
gio tests: add codegen to BUILT_SOURCES
Comment 2 Colin Walters 2014-03-07 13:19:53 UTC 
Review of attachment 271212 [details] [review]:

I am very happy we have a culture where even for basic one liners, we write clear and useful commit messages like this.
Comment 3 Koop Mast (kwm) 2014-03-07 13:21:03 UTC 
This patch allows glib to build on my FreeBSD jhbuild box. Which didn't want to build glib before without manual intervention.
Comment 4 Allison Karlitskaya (desrt) 2014-03-07 13:23:37 UTC 
Attachment 271212 [details] pushed as 66e2ffe - gio tests: add codegen to BUILT_SOURCES