After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725884 - support libsecret 0.18 (SecretUnstable to Secret API change)
support libsecret 0.18 (SecretUnstable to Secret API change)
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 731023 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-07 10:32 UTC by Olav Vitters
Modified: 2014-08-03 06:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch v1 (1.28 KB, patch)
2014-03-07 10:32 UTC, Olav Vitters 		committed Details | Review

Description Olav Vitters 2014-03-07 10:32:43 UTC 
Created attachment 271197 [details] [review]
patch v1

libsecret 0.18 moved a bunch of stuff from SecretUnstable to Secret.

See attached patch for something untested. Probably needs to increase the libsecret version requirement in configure.ac.
Comment 1 gnome.vrb 2014-07-09 19:31:21 UTC 
I'm encountering the following message, while starting rhythmbox ( latest git code ) in gnome-terminal ( debian sid amd64 ). 

ERROR:root:Could not find any typelib for SecretUnstable
Traceback (most recent call last):

+ Trace 233799

  • File "/usr/lib/rhythmbox/plugins/magnatune/magnatune.py", line 92 in do_activate 
    self.entry_type = MagnatuneEntryType()
  • File "/usr/lib/rhythmbox/plugins/magnatune/magnatune.py", line 50 in __init__ 
    self.account = MagnatuneAccount.instance()
  • File "/usr/lib/rhythmbox/plugins/magnatune/MagnatuneAccount.py", line 56 in instance 
    __instance = MagnatuneAccount()
  • File "/usr/lib/rhythmbox/plugins/magnatune/MagnatuneAccount.py", line 68 in __init__ 
    self.secret_service = SecretUnstable.Service.get_sync(SecretUnstable.ServiceFlags.OPEN_SESSION, None)
NameError: name 'SecretUnstable' is not defined 

Rhythmbox starts fine though.

As suggested in the description, it appears the libsecret's unstable API is mostly replaced with stable API's as part of the following change.

https://git.gnome.org/browse/libsecret/commit/?id=66e8949b7bad4b1b298146c5faeee0955bc71ac5

I agree with the bug reporter, that we should apply the patch for "plugins/magnatune/MagnatuneAccount.py" and make LIBSECRET_REQS=0.18

Jonathan, do you agree with this ?
Comment 2 gnome.vrb 2014-07-09 19:57:30 UTC 
"Rhythmbox starts fine though" ... but magantune plugin fails to load.

After applying the patch, the magnatune plugin works fine.
Comment 3 Jonathan Matthew 2014-08-03 06:13:37 UTC 
*** Bug 731023 has been marked as a duplicate of this bug. ***
Comment 4 Jonathan Matthew 2014-08-03 06:22:39 UTC 
pushed as commit f370706 along with the LIBSECRET_REQS change