After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725879 - rtsp-client: headers in GET response not configurable for tunnels
rtsp-client: headers in GET response not configurable for tunnels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-07 09:53 UTC by David Svensson Fors
Modified: 2014-03-11 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vmethod for modifying tunnel GET response (2.55 KB, patch)
2014-03-07 09:53 UTC, David Svensson Fors 		none Details | Review

Description David Svensson Fors 2014-03-07 09:53:48 UTC 
Created attachment 271191 [details] [review]
vmethod for modifying tunnel GET response

We have two cases where we need to modify HTTP headers in the response to the GET request for tunneled RTSP connections with gst-rtsp-server:

* We sometimes need to remove "Connection: close"
* We sometimes need to remove X-Server-IP-Address

The attached suggested patch makes it possible to do so, together with a fix for Bug #725878 (gst-plugins-base). We add a vmethod tunnel_http_response in GstRTSPClient and call it in the handler for a new GstRTSPWatch callback.
Comment 1 Wim Taymans 2014-03-10 14:10:07 UTC 
I would like to reuse the handle_response() vmethod for this.
Comment 2 Wim Taymans 2014-03-11 10:18:23 UTC 
Using a signal is not a good idea, commited it with some small changes (Since tag, keep ABI compatible)

commit faf0b31cbbdeba09217027fb9133946a3a72cf05
Author: David Svensson Fors <davidsf@axis.com>
Date:   Thu Mar 6 13:52:02 2014 +0100

    rtsp-client: vmethod for modifying tunnel GET response
    
    Add a vmethod tunnel_http_response where the response to the HTTP GET
    for tunneled connections can be modified.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725879