After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725822 - get_pretty_name mixes up ASCII and UTF8 characters
get_pretty_name mixes up ASCII and UTF8 characters
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-06 14:03 UTC by Debarshi Ray
Modified: 2014-03-07 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
places-bookmarks: UTF-8 characters may take more than a single byte (1.96 KB, patch)
2014-03-06 14:10 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-03-06 14:03:57 UTC 
For a suitably sized input text (longer than MAX_LEN_LABEL) get_pretty_name will smash the stack. If you build with -fstack-protector-strong, this will lead to a crash.
Comment 1 Debarshi Ray 2014-03-06 14:10:57 UTC 
Created attachment 271104 [details] [review]
places-bookmarks: UTF-8 characters may take more than a single byte
Comment 2 Cosimo Cecchi 2014-03-07 14:53:40 UTC 
Review of attachment 271104 [details] [review]:

Looks good, thanks.
Comment 3 Debarshi Ray 2014-03-07 16:43:46 UTC 
Comment on attachment 271104 [details] [review]
places-bookmarks: UTF-8 characters may take more than a single byte

Thanks for the review.