After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725816 - Don't close connect dialog when showing help
Don't close connect dialog when showing help
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-06 12:07 UTC by Marek Kašík
Modified: 2014-03-06 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't close connect dialog when showing help (2.92 KB, patch)
2014-03-06 12:07 UTC, Marek Kašík 		committed Details | Review

Description Marek Kašík 2014-03-06 12:07:15 UTC 
Created attachment 271088 [details] [review]
Don't close connect dialog when showing help

When user clicks on the "Help" button in the "Connect" dialog the dialog is closed and the help is shown to the user.
Better behaviour would be to not close the dialog and just open the help so the user doesn't need to open the connect dialog again.

Attached is a patch which does this for me.

Marek
Comment 1 David King 2014-03-06 12:14:48 UTC 
Comment on attachment 271088 [details] [review]
Don't close connect dialog when showing help

Looks fine, please push.
Comment 2 Marek Kašík 2014-03-06 12:37:04 UTC 
Comment on attachment 271088 [details] [review]
Don't close connect dialog when showing help

Thank you for the review. I've pushed the fix to master.