After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725815 - Fix leaking a webview reference in EphySnapshotService
Fix leaking a webview reference in EphySnapshotService
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-06 11:54 UTC by Yosef Or Boczko
Modified: 2014-03-14 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-title-box: Set the handler notify::title id to zero after disconnect (1.12 KB, patch)
2014-03-06 11:57 UTC, Yosef Or Boczko
none Details | Review
ephy-title-box: Fix leaking a webview reference (1.65 KB, patch)
2014-03-06 11:58 UTC, Yosef Or Boczko
rejected Details | Review
ephy-snapshot-service: Port to GTask (36.10 KB, patch)
2014-03-11 14:52 UTC, Carlos Garcia Campos
committed Details | Review

Description Yosef Or Boczko 2014-03-06 11:54:37 UTC
.
Comment 1 Yosef Or Boczko 2014-03-06 11:57:39 UTC
Created attachment 271086 [details] [review]
ephy-title-box: Set the handler notify::title id to zero after disconnect
Comment 2 Yosef Or Boczko 2014-03-06 11:58:11 UTC
Created attachment 271087 [details] [review]
ephy-title-box: Fix leaking a webview reference

I know this isn't right, but I think it work, not sure why.
Comment 3 Carlos Garcia Campos 2014-03-11 11:43:34 UTC
The title box is not the one leaking the web view, it's the snapshot service.
Comment 4 Yosef Or Boczko 2014-03-11 11:45:31 UTC
Review of attachment 271087 [details] [review]:

This isn't right (the ephy_title_box_finalize() never call).
Comment 5 Carlos Garcia Campos 2014-03-11 14:52:21 UTC
Created attachment 271525 [details] [review]
ephy-snapshot-service: Port to GTask