After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725752 - Non-specified dependency on PackageKit >= 0.9.1
Non-specified dependency on PackageKit >= 0.9.1
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-05 20:42 UTC by Dominique Leuenberger
Modified: 2014-03-07 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build with PackageKit < 0.9.1 (919 bytes, patch)
2014-03-05 20:47 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2014-03-05 20:42:17 UTC 
Building gnome-software 3.11.91 results in this warning (which OBS rightly raises to an error in the BRP checks):

[  133s] gs-plugin-packagekit-refine.c: In function 'gs_plugin_packagekit_refine_details_app':
[  133s] gs-plugin-packagekit-refine.c:504:10: warning: implicit declaration of function 'pk_details_get_summary' [-Wimplicit-function-declaration]

The issue being pl_details_get_summary only being available in PackageKit >= 0.9.1

the first usage of pk_details_get_summary is guarded by
#if PK_CHECK_VERSION(0,9,1)

later on, this is no longer done.
Comment 1 Dominique Leuenberger 2014-03-05 20:47:40 UTC 
Created attachment 271033 [details] [review]
Fix build with PackageKit < 0.9.1
Comment 2 Matthias Clasen 2014-03-05 23:30:25 UTC 
Review of attachment 271033 [details] [review]:

looks ok to me
Comment 3 Dominique Leuenberger 2014-03-07 22:58:30 UTC 
Attachment 271033 [details] pushed as b3629ae - Fix build with PackageKit < 0.9.1