After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725693 - Build error with lasem 0.4.1
Build error with lasem 0.4.1
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
0.10.x
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2014-03-04 22:47 UTC by Dominique Leuenberger
Modified: 2014-03-05 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (2.51 KB, patch)
2014-03-05 06:35 UTC, Jean Bréfort
none Details | Review
Fixed patch (2.29 KB, patch)
2014-03-05 07:03 UTC, Jean Bréfort
none Details | Review
patch with appropriate declarations. (2.41 KB, patch)
2014-03-05 07:14 UTC, Jean Bréfort
committed Details | Review

Description Dominique Leuenberger 2014-03-04 22:47:54 UTC
goffice 0.10.12 requires, as per configure.ac lasem-0.4 >= 0.4.1 (or lasem-0.6).

A build with lasem 0.4.1 though fails like this

[ 1172s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/goffice-0.10.12/plugins/lasem'
[ 1172s]   CC       component.lo
[ 1172s]   ITMRG  plugin.xml
[ 1174s] component.c: In function 'go_lasem_component_edit':
[ 1174s] component.c:194:40: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
[ 1174s]                                         GTK_STOCK_CLOSE, GTK_RESPONSE_CANCEL,
[ 1174s]                                         ^
[ 1174s] component.c:195:40: warning: 'GtkStock' is deprecated [-Wdeprecated-declarations]
[ 1174s]                                         GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT,
[ 1174s]                                         ^
[ 1174s] component.c: In function 'go_lasem_component_get_data':
[ 1174s] component.c:240:3: error: implicit declaration of function 'lsm_itex_to_mathml' [-Werror=implicit-function-declaration]
[ 1174s]    *data = lsm_itex_to_mathml (buf, strlen (buf));
[ 1174s]    ^
[ 1174s] component.c:240:3: error: nested extern declaration of 'lsm_itex_to_mathml' [-Werror=nested-externs]
[ 1174s] component.c:240:9: warning: assignment makes pointer from integer without a cast [enabled by default]
[ 1174s]    *data = lsm_itex_to_mathml (buf, strlen (buf));
[ 1174s]          ^
[ 1174s] component.c:243:33: error: 'lsm_itex_free_mathml_buffer' undeclared (first use in this function)
[ 1174s]    *clearfunc = (GDestroyNotify) lsm_itex_free_mathml_buffer;
[ 1174s]                                  ^
[ 1174s] component.c:243:33: note: each undeclared identifier is reported only once for each function it appears in
[ 1174s] cc1: some warnings being treated as errors
[ 1174s] Makefile:520: recipe for target 'component.lo' failed
Comment 1 Jean Bréfort 2014-03-05 06:11:48 UTC
Yes, known issue, my bad. I used those two functions that only exist in the current git version. I'll attach a patch as soon as posible.
Comment 2 Jean Bréfort 2014-03-05 06:35:52 UTC
Created attachment 270961 [details] [review]
Patch

Should fix the issue. Please test.
Comment 3 Jean Bréfort 2014-03-05 07:03:41 UTC
Created attachment 270962 [details] [review]
Fixed patch

I was bad, not patched the right file. This one should work.
Comment 4 Jean Bréfort 2014-03-05 07:14:44 UTC
Created attachment 270963 [details] [review]
patch with appropriate declarations.

Sorry once more. I should have checked if it really worked. This one does work.
Comment 5 Jean Bréfort 2014-03-05 14:41:25 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.