GNOME Bugzilla – Bug 725689
libtracker-extract: no longer use libtool versioning
Last modified: 2014-03-24 12:44:19 UTC
Maintaining the LT versions for a private library is useless.
Created attachment 270950 [details] [review] libtracker-extract: no longer use libtool versioning As a private library, there is no reason to maintain LT versioning.
Created attachment 270952 [details] [review] libtracker-extract: no longer use libtool versioning As a private library, there is no reason to maintain LT versioning.
Created attachment 270953 [details] [review] Addon patch: do the same for libtracker-common and libtracker-data
Looks good to me. I would just merge the two separate patches into a single one. It's cleaner this way.
Created attachment 270956 [details] [review] Patches merged Sure; merging makes sense... this was originally reported 'just' for the newly private library... and discussed on IRC; and the two additional libs common and data were noted to be equally affected.
So, I've test-built the Debian package with this patch, and now I'm getting loads of those warnings: dpkg-shlibdeps: warning: can't extract name and version from library name 'libtracker-common.so' dpkg-shlibdeps: warning: can't extract name and version from library name 'libtracker-extract.so' dpkg-shlibdeps: warning: can't extract name and version from library name 'libtracker-data.so' Typically, -avoid-version is used for dlopen'ed libraries, but in case of tracker they are linked like regular system libraries (that's why the RPATH) is necessary. Maybe it's better to not use -avoid-version but not explicitly set -version-info, i.e. use the default, which is 0.0.0
(In reply to comment #6) > So, I've test-built the Debian package with this patch, and now I'm getting > loads of those warnings: > > dpkg-shlibdeps: warning: can't extract name and version from library name > 'libtracker-common.so' > dpkg-shlibdeps: warning: can't extract name and version from library name > 'libtracker-extract.so' > dpkg-shlibdeps: warning: can't extract name and version from library name > 'libtracker-data.so' To be specific, with this patch I get 448 of those warning messages during a single package build.
Created attachment 272180 [details] [review] Updated patch to avoid build warnings Hi guys, So I think what we want is this patch. Michael, can you confirm this works for you? Stable releases are coming up and I would like to have this in ASAP, thanks :)
Hi Martin, after some consideration, I'd like to keep the status quo. It doesn't really fix any issue and is mostly of cosmetic nature. And it makes the Debian build process drown in error messages, making it harder to spot real issues/errors.
It = this patch
(In reply to comment #9) > Hi Martin, > > after some consideration, I'd like to keep the status quo. > It doesn't really fix any issue and is mostly of cosmetic nature. And it makes > the Debian build process drown in error messages, making it harder to spot real > issues/errors. Ah ok, I thought my newer patch would remove the warnings/errors you're seeing? If it doesn't I agree with you.
Oh, sorry. Completely missed your updated patch. Yeah, that one would be ok from my POV
(In reply to comment #12) > Oh, sorry. Completely missed your updated patch. > Yeah, that one would be ok from my POV OK, want to test or should I just push the commit?
(In reply to comment #13) > (In reply to comment #12) > > Oh, sorry. Completely missed your updated patch. > > Yeah, that one would be ok from my POV > > OK, want to test or should I just push the commit? I'm pretty sure your patch won't trigger the warnings. So, should be fine.
*** Bug 726963 has been marked as a duplicate of this bug. ***