GNOME Bugzilla – Bug 725649
All tabs are initially shown as loading empty pages when loading the session
Last modified: 2014-03-10 10:19:29 UTC
When not using the delayed requests, ephy at start up shows all the restored tabs loading with the title "Blank Page". Then you can see how while the pages are actually loaded, when they receive the title, tabs change their title one by one. Since page titles are saved in the session, we can use it as initial title of the tab and never shown the Blank Page. The title will be updated anyway when received during the page load.
Created attachment 270891 [details] [review] ephy-web-view: Remove ephy_web_view_get_title_composite() This is currently only used to set the window title and it's not actually needed, since we don't show Loading string in title anymore, only in the status bar. This is consistent with the title box and tabs title.
Created attachment 270892 [details] [review] ephy-web-view: Rename set_loading_title as set_loading_message This is no longer used to set a loading title, since it's always called with a URL or NULL. Also make it static since it's only used by ephy-web-view.c. Remove the public getter since it's unused too.
Created attachment 270893 [details] [review] ephy-web-view: Remove status_message member The status message is actually a combination of the loading message and link message, and both are already members.
Created attachment 270894 [details] [review] ephy-web-view: Move get_title_from_address to ephy-embed-utils
Created attachment 270895 [details] [review] ephy-web-view: Move embed-title property to EphyEmbed Since it's the embed title what it represents. The web view already has a title property inherited from WebKitWebView.
Created attachment 270896 [details] [review] Add title parameter to ephy_shell_new_tab_full to create tabs with an initial title And use it from ephy-session so that when loading the session and not using delayed requests, you don't see all the tabs initially with "Blank Page" title.
Created attachment 270924 [details] [review] Add title parameter to ephy_shell_new_tab_full to create tabs with an initial title And use it from ephy-session so that when loading the session and not using delayed requests, you don't see all the tabs initially with "Blank Page" title.
Created attachment 271103 [details] [review] ephy-web-view: Move embed-title property to EphyEmbed Since it's the embed title what it represents. The web view already has a title property inherited from WebKitWebView.