GNOME Bugzilla – Bug 725612
[review] add some logging functions to th/platform_link_logging
Last modified: 2014-03-13 20:46:01 UTC
while debugging something, I added a few to_string functions for netlink objects and for NMPlatformLink.
I don't feel strongly about them, they are not really used at the moment. But I think in general it's useful to be able to print our objects.
so, what do you think? Look at th/platform_link_logging
Branch looks OK to me.
I didn't find any issue in the code. Thanks for that, the enhanced debugging will certainly help us identifying potential problems.
Just a nit-picking:
> platform: extract function nm_platform_addr_flags2str() to wrap rtnl_addr_flags2str()
+ * so, check for that.
Use only one star in the comment ending "*/".
(In reply to comment #2)
> Just a nit-picking:
> > platform: extract function nm_platform_addr_flags2str() to wrap rtnl_addr_flags2str()
> + * so, check for that.
> + **/
> Use only one star in the comment ending "*/".
Branch merged to master as http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=45a326d9c70f3b7235f6749186a6509de113ea72