GNOME Bugzilla – Bug 725584
launch-environment: don't disable GVFS
Last modified: 2016-02-12 07:34:48 UTC
As an optimization we currently disable gvfs in greeter sessions (since they'll never need it). Now that we launch initial-setup in the same sort of environment, we're running into trouble because it relies on GVFS for fetching remote avatars. This commit eliminates the optimzation. The other option would be to disable GVFS for greeters, but enable it for initial-setup. In order to keep things simple, we forgo that for now, but may reconsider at a later time.
Created attachment 270813 [details] [review] launch-environment: don't disable GVFS
Attachment 270813 [details] pushed as 446d061 - launch-environment: don't disable GVFS
*** Bug 725541 has been marked as a duplicate of this bug. ***
(In reply to comment #0) > The other option would be to > disable GVFS for greeters, but enable it for initial-setup. In order > to keep things simple, we forgo that for now, but may reconsider at > a later time. People have started noticing gvfs is starting at the login screen and don't like it. So, we should do a more surgical patch to enable GVFS only for initial-setup and not login screens. Reopening.
In Debian we have a patch to disable gvfs: http://anonscm.debian.org/viewvc/pkg-gnome/desktop/unstable/gdm3/debian/patches/93_disable_gvfs.patch?revision=41982&view=markup
Do you know why?
The patch is from Josselin, I'm not 100% sure of the rational anymore. Could be that the processes were not exiting properly(?).
The rationale is to avoid starting gvfs daemons and exposing them at the login prompt when we don’t need them. And we don’t need gnome-initial-setup in Debian anyway.
Created attachment 317947 [details] [review] Disable gvfsd on the login screen An exception is made for g-i-s.
Created attachment 317948 [details] [review] launch-environment: disable gvfs except in initial setup mode gnome-initial-setup needs gvfs for remote avatar lookup. The greeter does not.
Review of attachment 317948 [details] [review]: ::: daemon/gdm-launch-environment.c @@ +160,3 @@ + /* Inital setup needs gvfs for fetching remote avatars. */ + if (strcmp (launch_environment->priv->session_mode, INITIAL_SETUP_SESSION_MODE)) { please put != 0 here
Attachment 317948 [details] pushed as 5e81151 - launch-environment: disable gvfs except in initial setup mode
Also pushed fa0472f