GNOME Bugzilla – Bug 725550
Add test case for queue2 element
Last modified: 2014-03-05 19:21:04 UTC
When paused state in queue2, buffers and events should not be sent to linked element. Thus, this a test case for verify whether the buffers and events could be sent or not to linked element in paused state in order to confirm leakage of buffers and events. IMHO, I am not sure that whether this test case is needed or not. Anyway I attached my patch. Please review and test my patch for queue2.
Created attachment 270754 [details] [review] Add test case for queue2 element
I don't think this is correct. In PAUSED queue2 will send buffers and events as in PLAYING, just the sinks will behave differently and not advance the running time. Thus only one buffer in your test is accepted by the sink. What exactly is the problem you are seeing here or want to check for?
Thanks for your comment. What I meant is that streaming case with buffering. If there is a pipeline such as playbin which configures some elements that are souphttpsrc, queue2 and so on. In this case, I just want to verify that whether the events and buffers are sending to linked element or not in paused state for buffering.
They are and they should. Only the sink will block in PAUSED state.
Thus, you mean that this test case is for streaming with buffering not required. Right?
Yes, it's not testing any behaviour of queue2 but just the pausing behaviour of the sinks... which can be tested much easier. If you want to prepare a test for that, that would be accepted :) Thanks for working on this nonetheless, having more tests is definitely a good idea.