After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725518 - Crash on context menu on misspelled work with no suggestions
Crash on context menu on misspelled work with no suggestions
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
unspecified
Other Linux
: Normal critical
: 0.6.0
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-03-02 20:47 UTC by Robert Schroll
Modified: 2014-03-05 02:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workaround (2.15 KB, patch)
2014-03-02 21:17 UTC, Robert Schroll 		none Details | Review

Description Robert Schroll 2014-03-02 20:47:20 UTC 
As reported by Mattias Eriksson on the mailing list: Geary crashes if you right click on a misspelled word that doesn't have any spelling suggestions.  (A long series of z's works.)

The first option on the default context menu in this case is a disabled item saying "No Guesses Found".  The webkit_context_menu_item_get_action function should return WEBKIT_CONTEXT_MENU_ACTION_NO_GUESSES_FOUND (I think), but instead it falls through to a g_assert_not_reached(), bringing everything down.  This is in WebKitGTK 1.10, but the source for 2.2 and 2.4 seems to be unchanged.

I haven't found an upstream bug about this; I suppose we should report it.
Comment 1 Robert Schroll 2014-03-02 21:17:15 UTC 
Created attachment 270726 [details] [review]
workaround

This works around the problematic call by noting that it's the only one that is insensitive.
Comment 2 Charles Lindsay 2014-03-03 18:36:52 UTC 
Thanks Robert and Mattias, we'll take a look at this soon.
Comment 3 Charles Lindsay 2014-03-05 02:09:32 UTC 
This looks good, thanks!  Fixed in commit 5bb9349.