After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725515 - test-printf fails on W32
test-printf fails on W32
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 19:17 UTC by LRN
Modified: 2014-08-02 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix printf-tests on W32 by enabling binary mode in the test (1.02 KB, patch)
2014-03-02 19:17 UTC, LRN
none Details | Review
Fix printf-tests on W32 by enabling binary mode in the test (1.02 KB, patch)
2014-04-21 17:34 UTC, LRN
needs-work Details | Review
Fix printf-tests on W32 by enabling binary mode in the test (1.10 KB, patch)
2014-07-28 12:29 UTC, LRN
reviewed Details | Review
Fix printf-tests on W32 by ifdefing the expected output (2.07 KB, patch)
2014-08-02 12:23 UTC, LRN
committed Details | Review

Description LRN 2014-03-02 19:17:26 UTC
It expects the child to output text with '\n' EOLs, but the child stdout
defaults to text mode, and the output contains '\r\n' EOLs.
Comment 1 LRN 2014-03-02 19:17:29 UTC
Created attachment 270716 [details] [review]
Fix printf-tests on W32 by enabling binary mode in the test
Comment 2 LRN 2014-04-21 17:34:09 UTC
Created attachment 274827 [details] [review]
Fix printf-tests on W32 by enabling binary mode in the test

v2: same thing, just attached with git bz
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-07-28 10:39:32 UTC
Review of attachment 274827 [details] [review]:

A comment why this is needed would be good.
Comment 4 LRN 2014-07-28 12:29:38 UTC
Created attachment 281864 [details] [review]
Fix printf-tests on W32 by enabling binary mode in the test

v2: added a comment that explains why binary mode is enabled
Comment 5 Ignacio Casal Quinteiro (nacho) 2014-07-31 15:46:55 UTC
Review of attachment 281864 [details] [review]:

Looks good to me. Let's get an ack from somebody.
Comment 6 Paolo Borelli 2014-08-02 08:57:08 UTC
Review of attachment 281864 [details] [review]:

Is the failing tests just the ones that use g_test_trap_assert_stdout ?

If yes, then it is just in two places, and one of them is already ifdeffed... if that's the case I think I would prefer to explicitly assert that the output matches \r\n on windows, instead of relaying on the binary flag
Comment 7 LRN 2014-08-02 12:23:21 UTC
Created attachment 282328 [details] [review]
Fix printf-tests on W32 by ifdefing the expected output

test-printf passes with this patch as well.
Comment 8 Paolo Borelli 2014-08-02 12:27:25 UTC
Review of attachment 282328 [details] [review]:

looks good
Comment 9 LRN 2014-08-02 12:31:53 UTC
Attachment 282328 [details] pushed as 40650e3 - Fix printf-tests on W32 by ifdefing the expected output