After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725511 - Compiled resource files should have the same /-separators everywhere
Compiled resource files should have the same /-separators everywhere
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 18:52 UTC by LRN
Modified: 2014-08-05 21:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Compiled resource files should have the same /-separators everywhere (1.36 KB, patch)
2014-03-02 18:52 UTC, LRN 		none Details | Review
Make sure compiled resources only have / as dirsep (1.34 KB, patch)
2014-04-21 17:10 UTC, LRN 		none Details | Review
Make sure compiled resources only have / as dirsep (1.01 KB, patch)
2014-08-04 15:05 UTC, LRN 		committed Details | Review

Description LRN 2014-03-02 18:52:49 UTC 
This is required for compatibility with MSYS, otherwise gtk will, for
example fail to build with:
No rule to make target '../../gtk+-3.11.5/gtk/resources\ui/gtkfontchooserdialog.ui', needed by 'gtkresources.c'
Comment 1 LRN 2014-03-02 18:52:53 UTC 
Created attachment 270709 [details] [review]
Compiled resource files should have the same /-separators everywhere
Comment 2 LRN 2014-04-21 17:10:33 UTC 
Created attachment 274820 [details] [review]
Make sure compiled resources only have / as dirsep

v2: same thing, just pushed with git bz
Comment 3 LRN 2014-08-04 15:02:31 UTC 
Tried to alter the patch, only use "/" as a separator in the second hunk. Doesn't work.

Tried to alter the patch, only use "/" as a separator in the first hunk. That works OK.
Comment 4 LRN 2014-08-04 15:05:01 UTC 
Created attachment 282455 [details] [review]
Make sure compiled resources only have / as dirsep

v2: Cut in half the number of changes needed for this to work
Comment 5 Matthias Clasen 2014-08-05 21:12:50 UTC 
Review of attachment 282455 [details] [review]:

looks fine to me
Comment 6 LRN 2014-08-05 21:50:45 UTC 
Attachment 282455 [details] pushed as 3c6efd4 - Make sure compiled resources only have / as dirsep