After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725493 - Consolidate message waiting code
Consolidate message waiting code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal enhancement
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 09:51 UTC by deathsimple@vodafone.de
Modified: 2014-07-23 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (10.89 KB, patch)
2014-03-10 09:44 UTC, deathsimple@vodafone.de 		needs-work Details | Review
V2 of the Patch. (11.27 KB, patch)
2014-03-12 13:00 UTC, deathsimple@vodafone.de 		committed Details | Review

Description deathsimple@vodafone.de 2014-03-02 09:51:58 UTC 
The attached patch depends on solving bug 725468 and consolidates the message waiting code into a single function instead of repeating it over and over again.
Comment 1 Sebastian Dröge (slomo) 2014-03-02 11:05:59 UTC 
You forgot to attach the patch :)

I'll try to find some time to review your patches later today
Comment 2 deathsimple@vodafone.de 2014-03-10 09:44:46 UTC 
Created attachment 271406 [details] [review]
Patch

Ups, yeah that sometimes happens when I'm clicking to wildly on the website.
Comment 3 Sebastian Dröge (slomo) 2014-03-12 07:45:26 UTC 
Review of attachment 271406 [details] [review]:

Thanks for the patch, in general looks good but:

::: omx/gstomx.c
@@ -1489,3 @@
-                && port->buffers->len >
-                g_queue_get_length (&port->pending_buffers)))
-          err = OMX_ErrorTimeout;

You're removing this part of the code without a replacement

@@ -1944,3 @@
-      if (port->buffers
-          && port->buffers->len > g_queue_get_length (&port->pending_buffers))
-        err = OMX_ErrorTimeout;

And this

@@ -2158,3 @@
-    if (add == 0) {
-      if (port->enabled_pending || port->disabled_pending)
-        err = OMX_ErrorTimeout;

And this
Comment 4 deathsimple@vodafone.de 2014-03-12 13:00:04 UTC 
Created attachment 271598 [details] [review]
V2 of the Patch.
Comment 5 Sebastian Dröge (slomo) 2014-03-12 13:05:28 UTC 
commit 0700d6875f5222b156453d9c58cd9c4d24860a13
Author: Christian König <christian.koenig@amd.com>
Date:   Sun Mar 2 10:30:04 2014 +0100

    omx: consolidate message waiting code
    
    Add a wait_message helper function and remove all those duplicated code.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=725493