After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725476 - adapter: Added interfaces for language bindings
adapter: Added interfaces for language bindings
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 03:05 UTC by Sebastian Rasmussen
Modified: 2014-03-15 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for making gst_buffer_extract() easier on language bindings. (4.58 KB, patch)
2014-03-02 03:06 UTC, Sebastian Rasmussen
needs-work Details | Review
Proposed patch for making gst_adapter_copy() easier on language bindings. (3.87 KB, patch)
2014-03-02 03:07 UTC, Sebastian Rasmussen
needs-work Details | Review
Proposed patch for making gst_adapter_copy() easier on language bindings. (3.87 KB, patch)
2014-03-14 16:45 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2014-03-02 03:05:14 UTC
Similar to https://bugzilla.gnome.org/show_bug.cgi?id=698562 I have discovered that the gst_buffer_extract() and gst_adapter_copy() interfaces are difficult to work with using the python bindings.

Therefore I propose two new interfaces in the same vein as 698562 to make the interfaces easier to work with.

I was unsure what Since:-tag to use, so I guessed at 1.3.0. Please let me know if needs to be changed.
Comment 1 Sebastian Rasmussen 2014-03-02 03:06:48 UTC
Created attachment 270665 [details] [review]
Proposed patch for making gst_buffer_extract() easier on language bindings.
Comment 2 Sebastian Rasmussen 2014-03-02 03:07:05 UTC
Created attachment 270666 [details] [review]
Proposed patch for making gst_adapter_copy() easier on language bindings.
Comment 3 Sebastian Dröge (slomo) 2014-03-03 19:23:08 UTC
Comment on attachment 270665 [details] [review]
Proposed patch for making gst_buffer_extract() easier on language bindings.

Since 1.4 and make this just a simple wrapper around extract_dup() :)

Also what's the effective difference between that and extract_dup()?
Comment 4 Sebastian Dröge (slomo) 2014-03-03 19:24:19 UTC
Comment on attachment 270666 [details] [review]
Proposed patch for making gst_adapter_copy() easier on language bindings.

Since: 1.4 but otherwise seems like a good idea
Comment 5 Sebastian Rasmussen 2014-03-14 16:45:53 UTC
Created attachment 271924 [details] [review]
Proposed patch for making gst_adapter_copy() easier on language bindings.
Comment 6 Sebastian Dröge (slomo) 2014-03-15 12:17:01 UTC
Comment on attachment 271924 [details] [review]
Proposed patch for making gst_adapter_copy() easier on language bindings.

commit 3de939cb5b7c4fdf40a4f2b780a0ce620cd7b6ee
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Mar 1 23:18:44 2014 +0100

    adapter: Adapt gst_adapter_copy() for bindings
    
    This is done by introducing a new gst_adapter_copy_bytes() call that
    returns a GBytes structure.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725476