GNOME Bugzilla – Bug 725463
change bandwidth to DVBv5-API
Last modified: 2014-03-15 13:27:06 UTC
Created attachment 270644 [details] [review] change bandwidth to DVBv5-API DVBv5-API use not an enum for bandwidth value, but the real frequency.
While I agree on the intent of the patch, I'm worried this might be considered an API break (the property is no longer an enum but an integer). Maybe we should create a new property and mark the old one as deprecated. This should keep backwards compatibility.
How I can marked the old property as deprecated?
The dvb plugin is in gst-plugins-bad, so if it makes sense to remove properties I think we should consider doing that instead of cluttering the interface of the elements with lots of deprecated no-op properties.
Created attachment 270701 [details] [review] add compatabily
(In reply to comment #1) > While I agree on the intent of the patch, I'm worried this might be considered > an API break (the property is no longer an enum but an integer). > > Maybe we should create a new property and mark the old one as deprecated. This > should keep backwards compatibility. Edward, which name should have the new property? Or is it better to rename the old with a prefix (_dvbv3)? Not that we rename the new property in the future to the old name. How many apps use GStreamer 1.x with dvbsrc/dvbbasebin plugin? I thing no apps, but apps which use GSteamer 0.10 I have see many of it.
P.S. Bandwidth going to more flexibily. Today we have 1.172, 5, 6, 7, 8, 10 MHz.
Created attachment 270897 [details] [review] add bandwidth-hz property
commit fd8bda1c0384c84fc33922aef1559800d8400e2a Author: Stefan Ringel <linuxtv@stefanringel.de> Date: Tue Mar 4 13:19:55 2014 +0100 dvbsrc: mpegts: change bandwidth to DVBv5 values Signed-off-by: Stefan Ringel <linuxtv@stefanringel.de> https://bugzilla.gnome.org/show_bug.cgi?id=725463