GNOME Bugzilla – Bug 725456
grilo sometimes calls plugins with %20 instead of spaces
Last modified: 2014-03-27 18:45:53 UTC
grilo sometimes calls plugins with %20 instead of spaces. This confuses the regexes in the local-metadata plugin, for examle. A workaround for this is to call g_uri_unescape_string() on the path in the plugin, but that's not a proper solution in my opinion.
I'm a bit lost. What it means "grilo sometimes calls plugins"? Do you mean it calls the search with %20 instead of spaces in the search term? Which plugins exactly?
It happened in local-metadata. I added debug prints to see why my regex was only working sometime with no apparent outside reason, and discovered that grl_local_metadata_source_resolve() was called with %20 instead of spaces. For the same files, it sometimes happen and sometimes doesn't - very inconsistent. I assume this might happen in other plugins too, but I really don't know.
video_guess_values_from_uri() is sometimes being passed a TITLE (if one is available) or a URL. If a URL is passed (because there's no title available), we need to get the basename, and then unescape it before passing it to video_guess_values_from_uri().
Created attachment 273100 [details] [review] tests: Add test for episode resolution with URLs When passing a GrlMedia without a title, make sure to get the basename of the URL, and unescape it before trying to manipulate it. file:///home/test/My%20super%20series.S01E01.mp4 should give: My super series as the show name, not: My%20super%20series
Created attachment 273101 [details] [review] local-metadata: Fix %20 in deduced titles When passing a GrlMedia without a title, make sure to get the basename of the URL, and unescape it before trying to manipulate it.
Attachment 273100 [details] pushed as 68e45ff - tests: Add test for episode resolution with URLs Attachment 273101 [details] pushed as a7f7d03 - local-metadata: Fix %20 in deduced titles