After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725400 - Add night mode
Add night mode
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 740981 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-28 14:15 UTC by gozes17
Modified: 2015-04-01 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
application: Add support for Night Mode (4.02 KB, patch)
2014-12-10 18:30 UTC, Bastien Nocera
committed Details | Review

Description gozes17 2014-02-28 14:15:38 UTC
Night Mode is a option where you can invert the colors of a PDF, evince has this, effectively making a white page turn black and black font turn white. I find that when reading from any screen a white on black document hurts my eyes making it impossible to read for long periods of time. On the other hand, black on white is a joy when reading from a screen, specially source code from a book, and long reading session are not a problem. I would really to see this feature in Document Manager.
Comment 1 Debarshi Ray 2014-02-28 14:30:09 UTC
(In reply to comment #0)

> find that when reading from any screen a white on black document hurts my eyes
> making it impossible to read for long periods of time. On the other hand, black
> on white is a joy when reading from a screen, specially source code from a
> book, and long reading session are not a problem.

You mean it the other way round, right? By default text shows up as black on a white background. You want the ability to have white text on a black background.
Comment 2 gozes17 2014-02-28 14:36:26 UTC
(In reply to comment #1)
> (In reply to comment #0)
> 
> > find that when reading from any screen a white on black document hurts my eyes
> > making it impossible to read for long periods of time. On the other hand, black
> > on white is a joy when reading from a screen, specially source code from a
> > book, and long reading session are not a problem.
> 
> You mean it the other way round, right? By default text shows up as black on a
> white background. You want the ability to have white text on a black
> background.

Yes. Sorry about that
Comment 3 gozes17 2014-02-28 14:42:01 UTC
(In reply to comment #1)
> (In reply to comment #0)
> 
> > find that when reading from any screen a white on black document hurts my eyes
> > making it impossible to read for long periods of time. On the other hand, black
> > on white is a joy when reading from a screen, specially source code from a
> > book, and long reading session are not a problem.
> 
> You mean it the other way round, right? By default text shows up as black on a
> white background. You want the ability to have white text on a black
> background.

Yes. Sorry about that
Comment 4 Debarshi Ray 2014-02-28 14:45:02 UTC
Restoring ui-review and the summary.
Comment 5 Allan Day 2014-02-28 15:35:13 UTC
It could be nice to allow this for when you are reading a longer document. However:

1. I think it would make sense to add night mode as a part of a more general display settings popover. This could include things like screen brightness, two or three modes for colours, zoom (or font size) and sans vs serifs fonts.

2. We would need a way to transform the text and background colours without making images in documents look bad. This seems to happen in some cases with Evince.

We should be really careful about messing up the appearance of documents with these kinds of settings. With a reader app for web documents or ebooks, there is a lot more freedom to format text and reflow it. I suspect that PDF documents will not be so easy to work with in this way.
Comment 6 gozes17 2014-02-28 16:51:39 UTC
Allan, as far as I know evince just flips the colors without any reflow
Comment 7 gozes17 2014-03-02 17:45:43 UTC
(In reply to comment #5)
> It could be nice to allow this for when you are reading a longer document.
> However:
> 
> 1. I think it would make sense to add night mode as a part of a more general
> display settings popover. This could include things like screen brightness, two
> or three modes for colours, zoom (or font size) and sans vs serifs fonts.
> 
> 2. We would need a way to transform the text and background colours without
> making images in documents look bad. This seems to happen in some cases with
> Evince.
> 
> We should be really careful about messing up the appearance of documents with
> these kinds of settings. With a reader app for web documents or ebooks, there
> is a lot more freedom to format text and reflow it. I suspect that PDF
> documents will not be so easy to work with in this way.

On your second point, if you look at evince you will see that it also flip the colors of the images. If the color of an image is important then the user can flip back, bind to C-i, look at the picture and flip back again to continue reading.
Comment 8 Allan Day 2014-03-28 13:22:19 UTC
Marking as needinfo, since we don't have a good design for this yet. In general I like the idea, but we need to resolve the issues in comment 5 before proceeding.
Comment 9 Allan Day 2014-03-28 14:49:30 UTC
Actually, this is a bug. Let's use NEW and needsdesign. Apologies for the noise.
Comment 10 Debarshi Ray 2014-12-01 18:39:40 UTC
*** Bug 740981 has been marked as a duplicate of this bug. ***
Comment 11 Debarshi Ray 2014-12-01 18:46:40 UTC
bug 730012 and bug 675608 are loosely related.
Comment 12 Bastien Nocera 2014-12-10 18:30:54 UTC
Created attachment 292475 [details] [review]
application: Add support for Night Mode
Comment 13 Cosimo Cecchi 2014-12-10 23:12:45 UTC
Looks good - merged to master.

Attachment 292475 [details] pushed as bd6ce17 - application: Add support for Night Mode