After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725398 - make check fails
make check fails
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-28 13:24 UTC by Shivani Poddar
Modified: 2014-02-28 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Makes the tests work for depreciated libs too. (753 bytes, patch)
2014-02-28 13:24 UTC, Shivani Poddar
committed Details | Review

Description Shivani Poddar 2014-02-28 13:24:33 UTC
Created attachment 270562 [details] [review]
Makes the tests work for depreciated libs too. 

running $make check , in the /tests folder for gnome-weather fails with the following trace:

[spoddar@localhost ~]$ make check
make: *** No rule to make target `check'.  Stop.
[spoddar@localhost ~]$ cd checkout/gnome/gnome-weather/
[spoddar@localhost gnome-weather]$ cd tests/
[spoddar@localhost tests]$ make check
make  check-am
make[1]: Entering directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
make      \
        world_view.py         testutil.py  
make[2]: Entering directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
make[2]: Nothing to be done for `world_view.py'.
make[2]: Nothing to be done for `testutil.py'.
make[2]: Leaving directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
make  check-TESTS
make[2]: Entering directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
Creating logfile at /tmp/dogtail-spoddar/logs/world_view_20140228-181920_debug ...
Traceback (most recent call last):
  • File "./world_view.py", line 17 in <module>
    init()
  • File "/home/spoddar/checkout/gnome/gnome-weather/tests/testutil.py", line 69 in init
    settings = Gio.Settings(schema_id="org.gnome.Weather.Application")
TypeError: __init__() takes at least 2 arguments (1 given)

Exception ImportError: 'No module named os' in <bound method Lock.__del__ of <dogtail.utils.Lock object at 0x7f7d9e25ce50>> ignored
FAIL: world_view.py
===============================================================================
1 of 1 test failed
Please report to https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-weather
===============================================================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/spoddar/checkout/gnome/gnome-weather/tests'
make: *** [check] Error 2
Comment 1 Giovanni Campagna 2014-02-28 13:28:18 UTC
Pushed.
Get a git account now!