GNOME Bugzilla – Bug 725390
ipod displayed with an usb key icon
Last modified: 2018-09-21 17:39:29 UTC
Using gvfs 1.19.5 on trusty, an ipod nano is displayed with an usb key icon gvfs-mount output "Drive(2): Apple iPod Type: GProxyDrive (GProxyVolumeMonitorUDisks2) ids: unix-device: '/dev/sdb' themed icons: [drive-removable-media-usb] [drive-removable-media] [drive-removable] [drive] symbolic themed icons: [drive-removable-media-usb-symbolic] [drive-removable-media-symbolic] [drive-removable-symbolic] [drive-symbolic] [drive-removable-media-usb] [drive-removable-media] [drive-removable] [drive] is_media_removable=1 has_media=1 is_media_check_automatic=1 can_poll_for_media=0 can_eject=1 can_start=0 can_stop=0 start_stop_type=shutdown sort_key=01hotplug/1393584266419875" ideally it should be displayed as a music player instead
Icons are set, when model is named "iPod": if ((self->model != NULL) && (g_str_equal (self->model, "iPod") != FALSE)) { g_vfs_backend_set_icon_name (G_VFS_BACKEND(self), "multimedia-player-apple-ipod-touch"); g_vfs_backend_set_symbolic_icon_name (G_VFS_BACKEND(self), "multimedia-player-apple-ipod-touch-symbolic"); } It is possible your iPod has different model name (e.g. "Apple iPod" as in your output), however not sure how to check it easily...
what about checking if the model includes "iPod" rather than being an exact match? What are the odd that the model string includes "iPod" and is not an iPod? ;-)
The code you are refering to is in the afp backend/monitor right? The iPod nano I'm using is an quite old one and I don't think it's using afp though... Changing the g_str_equal() to be strstr() doesn't seem to fix the issue either
(In reply to comment #3) > The code you are refering to is in the afp backend/monitor right? The iPod nano > I'm using is an quite old one and I don't think it's using afp though... AFP is AppleTalk, you mean AFC. Indeed it won't use afc, older iPods are just mass storage devices. You probably need to fix it via a udev quirk that tells udisks the icon to use.
@Bastien: yes, I meant AFC, thanks for correcting that ;-) The icon used to be fine some cycles ago, do you know what changed? What would be the right component to add the udev quirk for the icon, udisk?
It could be also fixed in udisks (e.g. in udisks/udisksobjectinfo.c), but it isn't probably what Bastien means. You can write your own udev rules for, see: https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt But don't know where is right place for it...
> You can write your own udev rules sure, but I would prefer fixing the bug not only for me, so it feels like that rule should be shipped with a standard component. Do we have any that is currently shipping those sort of tweaks?
The way it's supposed to work with the old-style mass storage devices: * media-player-info ships a hwdb (or udev rules) to identify these devices by vendor/product ID, and add an ID_MEDIA_PLAYER=<name> udev property * gvfs' udisks backend recognizes that and adds a x-content/audio-player content type (https://git.gnome.org/browse/gvfs/commit/?id=4d39b17547648a) On IRC, Sebastien checked: E: ID_MEDIA_PLAYER=apple_video-ipod E: ID_MODEL=iPod so this part seems alright.
@Martin: not sure that content-type is still being used there? Looking to the code the icon comes from https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/gvfsudisks2volume.c#n317 which is a call to udisks_object_info_get_media_icon (info)
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gvfs/issues/226.