After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725355 - Do not crash if we happen to come across a filename we can't decode
Do not crash if we happen to come across a filename we can't decode
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-27 22:39 UTC by Dominique Leuenberger
Modified: 2014-03-03 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not crash if we happen to come across a filename we can't decode (998 bytes, patch)
2014-02-27 22:39 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2014-02-27 22:39:32 UTC 
For some reason I happen to have files on my disk which should have german umlauts in their name, but too much copying between systems must have broken that at one point.

It's reasonable that gnome-music can't show that (correct), but in the current situation, gnome-music simply crashes away when encountering any such file.

This patch addresses it in a crude way (showing something.. the file even plays!), which, imho, is better than crashing.
Comment 1 Dominique Leuenberger 2014-02-27 22:39:40 UTC 
Created attachment 270516 [details] [review]
Do not crash if we happen to come across a filename we can't decode
Comment 2 Vadim Rutkovsky 2014-03-03 09:51:26 UTC 
Review of attachment 270516 [details] [review]:

Thanks, pushed this as https://git.gnome.org/browse/gnome-music/commit/?id=fd195b8