After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725340 - Don't show network-offline in the top bar
Don't show network-offline in the top bar
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.12
Depends on:
Blocks:
 
 
Reported: 2014-02-27 17:45 UTC by Allan Day
Modified: 2014-03-11 14:04 UTC
See Also:
GNOME target: 3.12
GNOME version: 3.11/3.12

Attachments
network: Don't show network-offline-symbolic in the top bar (1.03 KB, patch)
2014-03-10 18:12 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Allan Day 2014-02-27 17:45:59 UTC 
This is a leftover bit of cleanup from bug 708966.

The model we're trying to consistently use for network status (and system status in general) is to show icons for capabilities when they are active or in use. The nice thing about this is that you can always go to the system menu to get more information about any of the icons that are displayed in the top bar. This helps to make it clear and understandable.

Showing network-offline is inconsistent with this - it confuses the model, and you can't get more information about what the icon means.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-03-10 18:12:59 UTC 
Created attachment 271458 [details] [review]
network: Don't show network-offline-symbolic in the top bar

This is against the designs.
Comment 2 Giovanni Campagna 2014-03-10 22:37:21 UTC 
Review of attachment 271458 [details] [review]:

Looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-03-11 14:01:36 UTC 
Attachment 271458 [details] pushed as 821768a - network: Don't show network-offline-symbolic in the top bar
Comment 4 Allan Day 2014-03-11 14:04:44 UTC 
Excellent. Thanks so much.