After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725334 - rtsp-sdp: The sdp framesize attribute should have the payload type
rtsp-sdp: The sdp framesize attribute should have the payload type
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-27 16:51 UTC by Linus Svensson
Modified: 2015-03-09 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add payload type to framesize attribute (1.42 KB, patch)
2014-02-27 16:58 UTC, Linus Svensson 		committed Details | Review

Description Linus Svensson 2014-02-27 16:51:06 UTC 
The sdp framesize attribute (discribed in RFC6064) should look like

a=framesize:<payload type number> <width>-<height>.

If it should be included, a payloader add a-framesize = <width>-<height>
to the caps. We need to insert the payload number before we add this to the sdp.
Comment 1 Linus Svensson 2014-02-27 16:58:18 UTC 
Created attachment 270492 [details] [review]
add payload type to framesize attribute
Comment 2 Sebastian Dröge (slomo) 2015-03-09 08:27:23 UTC 
The same (just the other way around) is also required for rtspsrc and sdpdemux, right?

commit 9dadaed2fd598a0abe146d042177086fdbeaed4a
Author: Linus Svensson <linussn@axis.com>
Date:   Wed Feb 26 22:34:06 2014 +0100

    rtsp-sdp: add payload type to the sdp framesize attribute
    
    The sdp framesize attribute is desribed in RFC6064. It is specified
    for payloading of H263 and has the following form
    a=framesize:<payload type> <width>-<height>. The <width>-<height> part
    should be added to the caps in a payloader and the <payload type> should
    be added by the rtsp-server.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=725334
Comment 3 Linus Svensson 2015-03-09 09:09:11 UTC 
I made a corresponding change for rtspsrc in https://bugzilla.gnome.org/show_bug.cgi?id=725335.