GNOME Bugzilla – Bug 725322
add help page to create playlist using albums
Last modified: 2014-03-18 07:18:48 UTC
Created attachment 270479 [details] [review] help page for creating playlist via albums added a help page for creating playlist using albums. please review. Thanks!
Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=cd0cd4f, thanks
(In reply to comment #1) > Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=cd0cd4f, thanks Hi Vadim, could you wait on a review from the docs team before pushing? there are a few language issues in that patch which need to be fixed.
(In reply to comment #2) > (In reply to comment #1) > > Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=cd0cd4f, thanks > > Hi Vadim, could you wait on a review from the docs team before pushing? there > are a few language issues in that patch which need to be fixed. Oops, sorry, reverted the commit. We're making a new 'user docs' component, which email should I use to make sure documentation team will get a notification for that?
(In reply to comment #3) > Oops, sorry, reverted the commit. Thanks :) > We're making a new 'user docs' component, which email should I use to make sure > documentation team will get a notification for that? gnome-user-docs-maint@gnome.bugs please
Created attachment 270534 [details] [review] help page for creating playlist via albums hi! kittykat, now the patch is having an updated Makefile.am too. :) and checked with jhbuild too. build sucessfully. Thanks!
Created attachment 270548 [details] [review] help page for creating playlist via albums corrected "id" the page tag's attribute from "create-playlist" to "create-playlist-via-albums". Thanks!
Created attachment 270821 [details] [review] help page for creating playlist via albums updated patch
Created attachment 270836 [details] [review] help page for creating playlist via albums
Comment on attachment 270836 [details] [review] help page for creating playlist via albums >+ <desc>Create playlist and add songs to it through albums.</desc> >+ <title>Create playlist by albums</title> "Create playlist" - noun needs some article. What does the "through" mean? Do I need to put songs through albums first in order to create playlists? >+ <p>You can view all your albums by clicking on <gui>Albums</gui> button.</p> If there's only one button in the interface, then the noun needs a definite article. Also, you should use <gui style="button">. >+ <title>To add all the song in the album:</title> Typo: all the song >+ <p>Click on the <em>check</em> button on the right side of the >+ toolbar.</p> I have not tried the UI, but is "check" really not capitalized? Why do you use <em> instead of <gui style="button"> if it's a button? >+ <gui>Select Playlist</gui> dailog will appear.</p> The noun needs a definite article, plus typo in "dailog" >+ <p>Click on <gui>Select</gui> button.</p> Either you need a definite article here, or you could drop "button". In any case, <gui> should be <gui style="button">. >+ <p>Click on the <em>check</em> button.</p> Same as above. >+ <p>Click on the <gui>Add to Playlist</gui> button. Should be <gui style="button">. You're using a "the" here, I like that. :) >+ <gui>Select Playlist</gui> dailog will appear.</p> Same as above. >+ <p>Click on <gui>Select</gui> button.</p> Should be <gui style="button"> and missing a definite article ("the") here. >+ <p>To select all albums click >+ <guiseq><gui>Click on items to select them >+ </gui><gui>Select All</gui></guiseq> on the toolbar or press >+ <keyseq><key>Ctrl</key><key>A</key></keyseq>.</p> Is "Click on items to select them" really a GUI item? If I read this aloud, you click click on items and then you select them select all on the toolbar.
Created attachment 270922 [details] [review] help page for creating playlist via albums corrected please review :) let me know the further corrections if any. thanks!
Review of attachment 270922 [details] [review]: ::: help/C/create-playlist-via-albums.page @@ +22,3 @@ + <p>You can view all your albums by clicking on the + <gui style="button">Albums</gui> button.</p> + <steps> Leave a blank line above here and also after the title. @@ +25,3 @@ + <title>To add all the songs in an album:</title> + <item> + <p>Click on the <em>check</em> button on the right side of the I wouldn't use <em> and I'd say "button in the top-right of the screen" @@ +30,3 @@ + <item> + <p>Click on the <gui style="button">Add to Playlist</gui> button. The + <gui>Select Playlist</gui> dialog will appear.</p> I don't think you need to say here that a dialog will appear. @@ +40,3 @@ + </item> + </steps> + <steps> Blank line between the lists please. @@ +43,3 @@ + <title>To add selected songs from an album:</title> + <item> + <p>Click on the album of your choice.</p> "Click on an album.". As you're not choosing it for the reader, then it's clearly their choice. @@ +77,3 @@ + </item> + </list> + </note> I recommend that you make these into two normal paragraphs instead of a list inside a note. ::: help/Makefile.am @@ +5,2 @@ HELP_FILES = \ + create-playlist-via-albums.page \ Drop the "via" from the page title.
Created attachment 271277 [details] [review] help page to create playlist using albums please review Thanks!
Review of attachment 271277 [details] [review]: Almost there :) ::: help/C/playlist-create-albums.page @@ +23,3 @@ + <p>You can view all your albums by clicking on the + <gui style="button">Albums</gui> button.</p> + <steps> Leave blank line between paragraph and steps. @@ +29,3 @@ + toolbar.</p> + </item> + <item> You need to select the albums that you want to add, before adding them, right? @@ +41,3 @@ + </steps> + + <steps> It would be nice if you could add a paragraph between the two steps lists, something along the lines of "you can also create a playlist from specific songs" @@ +66,3 @@ + <note> + <p>To select all the songs click + <guiseq><gui>Click on items to select them </gui><gui>Select All</gui></guiseq> Extra space before </gui>, please remove it. @@ +69,3 @@ + in the toolbar or press <keyseq><key>Ctrl</key><key>A</key></keyseq>.</p> + + <p>To clear selections click To clear "the selection" as there's only one selection at any given time (which can contain multiple items in it).
Created attachment 271320 [details] [review] help page for creating playlist using albums corrections done. please review :) Thanks!
Review of attachment 271320 [details] [review]: Please check your reflowing before you push.
patch pushed to master in the commit:f6d4e28916a86715b6736455bad5022a8204eb69
patch for Makefile.am is updated in the commit: 52ab6b1734145e58202b40e6acdd99b354b82e2a
please ignore the commit for Makefile.am above. patch for Makefile.am is updated in the commit: d45907853f362e168b23282411e2a21085e57631