After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725252 - Referencing terminals and tabs in menuitems.
Referencing terminals and tabs in menuitems.
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-26 18:15 UTC by Kat
Modified: 2014-03-03 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to use "Terminal" in menu (1.22 KB, patch)
2014-02-26 18:19 UTC, Kat 		none Details | Review
patch to use "Terminal" in menu (1.73 KB, patch)
2014-02-26 20:35 UTC, Kat 		none Details | Review

Description Kat 2014-02-26 18:15:45 UTC 
When right-clicking on a tab, the context menu shows "Move Tab Left/Right" and "Close Terminal". In my case, "Close Terminal" only closes the tab, so it's confusing to have "tab" and "terminal" used in one menu to reference the same thing. It would be more consistent to use "Move Terminal Left/Right" instead as that seems to be in line with the new "New Terminal" menuitem.
Comment 1 Kat 2014-02-26 18:19:44 UTC 
Created attachment 270407 [details] [review]
patch to use "Terminal" in menu
Comment 2 Christian Persch 2014-02-26 19:40:27 UTC 
Hmm. The same actions are used in the Tabs menu where calling them otherwise would be slightly weird? We could rename the TabsNext/TabsPrevious actions too.

If we do change the labels, they need to be changed in src/terminal-accels.c:tabs_entries[] too.
Comment 3 Kat 2014-02-26 20:14:00 UTC 
Good point, I didn't notice that. I think renaming everything except the menu itself to "terminal" would be appropriate because otherwise, we end up calling them "terminal" in some places and "tabs" in other places, which is confusing.
Comment 4 Christian Persch 2014-02-26 20:18:27 UTC 
Ok, let's do that :-)
Comment 5 Kat 2014-02-26 20:35:53 UTC 
Created attachment 270418 [details] [review]
patch to use "Terminal" in menu

I've made the changes in the patch. As far as I could tell, "Detach tab" was not used anywhere else, so I've changed the capitalisation to be header because of the HIG.