After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725143 - enumeration: add support for static methods
enumeration: add support for static methods
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-25 13:45 UTC by Giovanni Campagna
Modified: 2014-02-26 00:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
enumeration: add support for static methods (4.43 KB, patch)
2014-02-25 13:45 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-25 13:45:35 UTC 
gobject-introspection has supported these for a while, and it
costs nothing for us to support them as well. In addition, it
makes a lot simpler to have documentation (because we can simply
skip all the backward compatibility functions)
Comment 1 Giovanni Campagna 2014-02-25 13:45:37 UTC 
Created attachment 270270 [details] [review]
enumeration: add support for static methods
Comment 2 Colin Walters 2014-02-25 22:07:24 UTC 
Review of attachment 270270 [details] [review]:

Just one thing.

::: gi/enumeration.cpp
@@ +157,3 @@
+        flags = g_function_info_get_flags(meth_info);
+
+        g_warn_if_fail(!(flags & GI_FUNCTION_IS_METHOD));

Leftover?
Comment 3 Giovanni Campagna 2014-02-25 22:33:34 UTC 
(In reply to comment #2)
> Review of attachment 270270 [details] [review]:
> 
> Just one thing.
> 
> ::: gi/enumeration.cpp
> @@ +157,3 @@
> +        flags = g_function_info_get_flags(meth_info);
> +
> +        g_warn_if_fail(!(flags & GI_FUNCTION_IS_METHOD));
> 
> Leftover?

No, just safety in cases gobject-introspection becomes crazy and adds methods there.
Comment 4 Giovanni Campagna 2014-02-26 00:57:02 UTC 
Attachment 270270 [details] pushed as 5879819 - enumeration: add support for static methods