After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725128 - Disable the sharing dialog for non-Google content
Disable the sharing dialog for non-Google content
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-25 10:45 UTC by Debarshi Ray
Modified: 2014-03-05 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Let DocCommon children indicate whether they support sharing (2.75 KB, patch)
2014-02-25 13:24 UTC, Debarshi Ray 		committed Details | Review
documents: Warn that DocCommon implementations must override canTrash (885 bytes, patch)
2014-02-25 13:24 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-02-25 10:45:11 UTC 
SharingDialog assumes Google as the only non-local source, which is not true.
Comment 1 Debarshi Ray 2014-02-25 13:24:17 UTC 
Created attachment 270268 [details] [review]
documents: Let DocCommon children indicate whether they support sharing

This is a short term fix, because I do not want to venture into sharing support for SkyDrive and ownCloud during the freeze.
Comment 2 Debarshi Ray 2014-02-25 13:24:47 UTC 
Created attachment 270269 [details] [review]
documents: Warn that DocCommon implementations must override canTrash
Comment 3 Cosimo Cecchi 2014-02-25 16:20:30 UTC 
Review of attachment 270268 [details] [review]:

Looks good
Comment 4 Cosimo Cecchi 2014-02-25 16:20:57 UTC 
Review of attachment 270269 [details] [review]:

Sure
Comment 5 Debarshi Ray 2014-02-26 08:34:44 UTC 
Comment on attachment 270269 [details] [review]
documents: Warn that DocCommon implementations must override canTrash

Thanks for the review, Cosimo.
Comment 6 Debarshi Ray 2014-02-26 08:35:43 UTC 
Lets use a separate bug (maybe as a 3.14 feature) for implementing sharing support for some of the other sources.