After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725070 - Use TpAccountChannelRequest high level API
Use TpAccountChannelRequest high level API
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-24 15:26 UTC by Guillaume Desmottes
Modified: 2014-02-27 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
call-utils: inline call_new_with_streams() (1.53 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
empathy_call_new_with_streams: remove initial_audio arg (5.93 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
call-handler: remove 'initial-audio' prop (2.39 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
call-utils: use TpAccountChannelRequest higher level API (4.65 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
empathy-chat: use tp_account_channel_request_new_text() (1.59 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
share-my-desktop: use tp_account_channel_request_set_target_contact() (1.42 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
request-util: use TpAccountChannelRequest higher level API (1.89 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
tp-chat: use TpAccountChannelRequest higher level API (2.72 KB, patch)
2014-02-24 15:27 UTC, Guillaume Desmottes
committed Details | Review
ft-handler: use TpAccountChannelRequest higher level API (4.41 KB, patch)
2014-02-24 15:28 UTC, Guillaume Desmottes
committed Details | Review
bump tp-glib dep (1.05 KB, patch)
2014-02-26 10:55 UTC, Guillaume Desmottes
committed Details | Review
use tp_account_channel_request_new_stream_tube() (1.71 KB, patch)
2014-02-26 10:55 UTC, Guillaume Desmottes
committed Details | Review
use tp_account_channel_request_set_file_transfer_hash() (1.62 KB, patch)
2014-02-26 10:55 UTC, Guillaume Desmottes
committed Details | Review
use tp_account_channel_request_set_sms_channel() (1.03 KB, patch)
2014-02-26 10:55 UTC, Guillaume Desmottes
committed Details | Review
tp-chat: stop setting TargetHandleType: None (1.03 KB, patch)
2014-02-26 10:55 UTC, Guillaume Desmottes
committed Details | Review
use TpAccountChannelRequest Conference high level API (1.28 KB, patch)
2014-02-26 10:56 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2014-02-24 15:26:55 UTC
.
Comment 1 Guillaume Desmottes 2014-02-24 15:27:33 UTC
Created attachment 270139 [details] [review]
call-utils: inline call_new_with_streams()

We no longer support fallbacking to StreamedMedia so there is no point keeping
this static function.
Comment 2 Guillaume Desmottes 2014-02-24 15:27:36 UTC
Created attachment 270140 [details] [review]
empathy_call_new_with_streams: remove initial_audio arg

We always pass TRUE.
Comment 3 Guillaume Desmottes 2014-02-24 15:27:40 UTC
Created attachment 270141 [details] [review]
call-handler: remove 'initial-audio' prop

It was always set to TRUE anyway.
Comment 4 Guillaume Desmottes 2014-02-24 15:27:43 UTC
Created attachment 270142 [details] [review]
call-utils: use TpAccountChannelRequest higher level API
Comment 5 Guillaume Desmottes 2014-02-24 15:27:47 UTC
Created attachment 270143 [details] [review]
empathy-chat: use tp_account_channel_request_new_text()
Comment 6 Guillaume Desmottes 2014-02-24 15:27:50 UTC
Created attachment 270144 [details] [review]
share-my-desktop: use tp_account_channel_request_set_target_contact()
Comment 7 Guillaume Desmottes 2014-02-24 15:27:53 UTC
Created attachment 270145 [details] [review]
request-util: use TpAccountChannelRequest higher level API
Comment 8 Guillaume Desmottes 2014-02-24 15:27:58 UTC
Created attachment 270146 [details] [review]
tp-chat: use TpAccountChannelRequest higher level API
Comment 9 Guillaume Desmottes 2014-02-24 15:28:01 UTC
Created attachment 270147 [details] [review]
ft-handler: use TpAccountChannelRequest higher level API
Comment 10 Xavier Claessens 2014-02-25 18:10:55 UTC
+1
Comment 11 Guillaume Desmottes 2014-02-26 09:33:18 UTC
Merged to master. Not closing yet as I have a few more patches.

Attachment 270139 [details] pushed as 912bbee - call-utils: inline call_new_with_streams()
Attachment 270140 [details] pushed as 1fd36e1 - empathy_call_new_with_streams: remove initial_audio arg
Attachment 270141 [details] pushed as 6a1fee5 - call-handler: remove 'initial-audio' prop
Attachment 270142 [details] pushed as 25f83bd - call-utils: use TpAccountChannelRequest higher level API
Attachment 270143 [details] pushed as a58c33e - empathy-chat: use tp_account_channel_request_new_text()
Attachment 270144 [details] pushed as 4bf3c0d - share-my-desktop: use tp_account_channel_request_set_target_contact()
Attachment 270145 [details] pushed as dba5942 - request-util: use TpAccountChannelRequest higher level API
Attachment 270146 [details] pushed as 7bc22f4 - tp-chat: use TpAccountChannelRequest higher level API
Attachment 270147 [details] pushed as a8fc1ca - ft-handler: use TpAccountChannelRequest higher level API
Comment 12 Guillaume Desmottes 2014-02-26 10:55:43 UTC
Created attachment 270363 [details] [review]
bump tp-glib dep

Needed for newer TpAccountChannelRequest API.
Comment 13 Guillaume Desmottes 2014-02-26 10:55:47 UTC
Created attachment 270364 [details] [review]
use tp_account_channel_request_new_stream_tube()
Comment 14 Guillaume Desmottes 2014-02-26 10:55:51 UTC
Created attachment 270365 [details] [review]
use tp_account_channel_request_set_file_transfer_hash()
Comment 15 Guillaume Desmottes 2014-02-26 10:55:55 UTC
Created attachment 270366 [details] [review]
use tp_account_channel_request_set_sms_channel()
Comment 16 Guillaume Desmottes 2014-02-26 10:55:59 UTC
Created attachment 270367 [details] [review]
tp-chat: stop setting TargetHandleType: None

It's now down automatically by TpAccountChannelRequest.
Comment 17 Guillaume Desmottes 2014-02-26 10:56:04 UTC
Created attachment 270368 [details] [review]
use TpAccountChannelRequest Conference high level API
Comment 18 Xavier Claessens 2014-02-26 12:35:26 UTC
+1
Comment 19 Guillaume Desmottes 2014-02-27 11:12:10 UTC
Attachment 270363 [details] pushed as 96d5400 - bump tp-glib dep
Attachment 270364 [details] pushed as 0527780 - use tp_account_channel_request_new_stream_tube()
Attachment 270365 [details] pushed as d91d348 - use tp_account_channel_request_set_file_transfer_hash()
Attachment 270366 [details] pushed as ba5187f - use tp_account_channel_request_set_sms_channel()
Attachment 270367 [details] pushed as c661301 - tp-chat: stop setting TargetHandleType: None
Attachment 270368 [details] pushed as 8d7b620 - use TpAccountChannelRequest Conference high level API